Skip to content

Commit

Permalink
power: bq24190_charger: mark PM functions as __maybe_unused
Browse files Browse the repository at this point in the history
Without CONFIG_PM, we get a harmless warning:

drivers/power/supply/bq24190_charger.c:1514:12: error: 'bq24190_runtime_resume' defined but not used [-Werror=unused-function]
drivers/power/supply/bq24190_charger.c:1501:12: error: 'bq24190_runtime_suspend' defined but not used [-Werror=unused-function]

To avoid the warning, we can mark all four PM functions as __maybe_unused,
which also lets us remove the incorrect #ifdef.

Fixes: 3d8090c ("power: bq24190_charger: Check the interrupt status on resume")
Signed-off-by: Arnd Bergmann <[email protected]>
Acked-by: Tony Lindgren <[email protected]>
Acked-by: Liam Breck <[email protected]>
Signed-off-by: Sebastian Reichel <[email protected]>
  • Loading branch information
arndb authored and sre committed Apr 13, 2017
1 parent dba8347 commit b98074e
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions drivers/power/supply/bq24190_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -1498,7 +1498,7 @@ static int bq24190_remove(struct i2c_client *client)
return 0;
}

static int bq24190_runtime_suspend(struct device *dev)
static __maybe_unused int bq24190_runtime_suspend(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
Expand All @@ -1511,7 +1511,7 @@ static int bq24190_runtime_suspend(struct device *dev)
return 0;
}

static int bq24190_runtime_resume(struct device *dev)
static __maybe_unused int bq24190_runtime_resume(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
Expand All @@ -1527,8 +1527,7 @@ static int bq24190_runtime_resume(struct device *dev)
return 0;
}

#ifdef CONFIG_PM_SLEEP
static int bq24190_pm_suspend(struct device *dev)
static __maybe_unused int bq24190_pm_suspend(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
Expand All @@ -1550,7 +1549,7 @@ static int bq24190_pm_suspend(struct device *dev)
return 0;
}

static int bq24190_pm_resume(struct device *dev)
static __maybe_unused int bq24190_pm_resume(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
Expand Down Expand Up @@ -1580,7 +1579,6 @@ static int bq24190_pm_resume(struct device *dev)

return 0;
}
#endif

static const struct dev_pm_ops bq24190_pm_ops = {
SET_RUNTIME_PM_OPS(bq24190_runtime_suspend, bq24190_runtime_resume,
Expand Down

0 comments on commit b98074e

Please sign in to comment.