Read responseType property from the correct object

teamwire · Mar 17, 2017 · 626c2d4 · 626c2d4
1 parent a1a43aa
commit 626c2d4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/node/index.js b/lib/node/index.js
@@ -808,6 +808,7 @@ Request.prototype._end = function() {
     var multipart = 'multipart' == type;
     var redirect = isRedirect(res.statusCode);
     var parser = self._parser;
+    var responseType = self._responseType;
 
     self.res = res;
 
@@ -828,7 +829,7 @@ Request.prototype._end = function() {
     }
 
     if (!parser) {
-      if (this._responseType) {
+      if (responseType) {
         parser = exports.parse.image; // It's actually a generic Buffer
         buffer = true;
       } else if (multipart) {

diff --git a/test/node/image.js b/test/node/image.js
@@ -33,4 +33,17 @@ describe('res.body', function(){
       });
     });
   });
+  describe('application/octet-stream', function(){
+      it('should parse the body (using responseType)', function(done){
+          request
+              .get(base + '/image-as-octets')
+              .responseType('blob')
+              .end(function(err, res){
+                  res.type.should.equal('application/octet-stream');
+                  Buffer.isBuffer(res.body).should.be.true();
+                  (res.body.length - img.length).should.equal(0);
+                  done();
+              });
+      });
+  });
 });