Skip to content

Commit

Permalink
Downgrade maven for license check (apache#5874)
Browse files Browse the repository at this point in the history
The build fails with license check with maven 3.6.2 which is part of ubuntu-latest in gitlab actions, here we downgrade it get it to pass.

Move additional jobs to maven 3.6.1 to improve stability.
  • Loading branch information
aahmed-se authored and jiazhai committed Dec 27, 2019
1 parent aa83ad3 commit 4ec754c
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/ci-integration-sql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ jobs:
- name: checkout
uses: actions/checkout@v1

- name: Set up Maven
uses: aahmed-se/setup-maven@v3
with:
maven-version: 3.6.1

- name: build artifacts and docker image
run: mvn -B install -Dorg.slf4j.simpleLogger.defaultLogLevel=ERROR -Pdocker -DskipTests

Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/ci-license.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,13 @@ jobs:
- name: checkout
uses: actions/checkout@v1

- name: Setup Maven Version
run: mvn -B --version
# license check fails with 3.6.2 so we have to downgrade
- name: Set up Maven
uses: aahmed-se/setup-maven@v3
with:
maven-version: 3.6.1

- name: run unit tests
- name: build and check license
run: mvn -B -ntp -DskipTests license:check install

- name: license check
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/ci-unit-flaky.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,13 @@ jobs:
- name: checkout
uses: actions/checkout@v1

- name: Set up Maven
uses: aahmed-se/setup-maven@v3
with:
maven-version: 3.6.1

- name: run unit tests
run: mvn -B -Dorg.slf4j.simpleLogger.defaultLogLevel=ERROR install '-Dtest=PersistentTransactionBufferTest,PulsarFunctionE2ESecurityTest,ServerCnxTest,AdminApiOffloadTest,AdminApiSchemaValidationEnforced,V1_AdminApiTest2,ProxyPublishConsumeTlsTest,PulsarFunctionE2ETest,MessageIdSerialization,AdminApiTest2,PulsarFunctionLocalRunTest,PartitionedProducerConsumerTest,KafkaProducerSimpleConsumerTest' -DfailIfNoTests=false
run: mvn -B -Dorg.slf4j.simpleLogger.defaultLogLevel=ERROR install '-Dtest=PersistentTransactionBufferTest,PulsarFunctionE2ESecurityTest,ServerCnxTest,AdminApiOffloadTest,AdminApiSchemaValidationEnforced,V1_AdminApiTest2,ProxyPublishConsumeTlsTest,PulsarFunctionE2ETest,MessageIdSerialization,AdminApiTest2,PulsarFunctionLocalRunTest,PartitionedProducerConsumerTest,KafkaProducerSimpleConsumerTest,ProxyTest' -DfailIfNoTests=false

- name: package surefire artifacts
if: failure()
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/ci-unit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,13 @@ jobs:
- name: checkout
uses: actions/checkout@v1

- name: Set up Maven
uses: aahmed-se/setup-maven@v3
with:
maven-version: 3.6.1

- name: run unit tests
run: mvn -B -Dorg.slf4j.simpleLogger.defaultLogLevel=ERROR install '-Dtest=!PersistentTransactionBufferTest,!PulsarFunctionE2ESecurityTest,!ServerCnxTest,!AdminApiOffloadTest,!AdminApiSchemaValidationEnforced,!V1_AdminApiTest2,!ProxyPublishConsumeTlsTest,!PulsarFunctionE2ETest,!MessageIdSerialization,!AdminApiTest2,!PulsarFunctionLocalRunTest,!PartitionedProducerConsumerTest,!KafkaProducerSimpleConsumerTest' -DfailIfNoTests=false
run: mvn -B -Dorg.slf4j.simpleLogger.defaultLogLevel=ERROR install '-Dtest=!PersistentTransactionBufferTest,!PulsarFunctionE2ESecurityTest,!ServerCnxTest,!AdminApiOffloadTest,!AdminApiSchemaValidationEnforced,!V1_AdminApiTest2,!ProxyPublishConsumeTlsTest,!PulsarFunctionE2ETest,!MessageIdSerialization,!AdminApiTest2,!PulsarFunctionLocalRunTest,!PartitionedProducerConsumerTest,!KafkaProducerSimpleConsumerTest,!ProxyTest' -DfailIfNoTests=false

- name: package surefire artifacts
if: failure()
Expand Down

0 comments on commit 4ec754c

Please sign in to comment.