Skip to content

Commit

Permalink
Set configured TLS protocols to SSLEngine instance (apache#8581)
Browse files Browse the repository at this point in the history
Fixes apache#8580

### Motivation

See apache#8580 , some tests fail with newer Java 8 versions that include TLS1.3 protocol. This might also impact the runtime behavior of Pulsar.

### Modifications

Set the configured TLS protocols to the SSLEngine instance.
  • Loading branch information
lhotari authored Nov 19, 2020
1 parent ab000ec commit e18e8ca
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public SSLEngine createSSLEngine(String peerHost, int peerPort) {
}

private SSLEngine configureSSLEngine(SSLEngine sslEngine) {
sslEngine.setEnabledProtocols(sslEngine.getSupportedProtocols());
sslEngine.setEnabledProtocols(protocols.toArray(new String[0]));
sslEngine.setEnabledCipherSuites(sslEngine.getSupportedCipherSuites());

if (this.mode == Mode.SERVER) {
Expand Down

0 comments on commit e18e8ca

Please sign in to comment.