Do not return the promise from the deferred's methods.

See discussion in kriskowal#135.
tebriel · Nov 4, 2012 · 87d9254 · 87d9254
1 parent 0442ffa
commit 87d9254
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/q.js b/q.js
@@ -490,15 +490,14 @@ function defer() {
         }, void 0);
         pending = void 0;
         progressListeners = void 0;
-        return value;
     }
 
     defend(promise);
 
     deferred.promise = promise;
     deferred.resolve = become;
     deferred.reject = function (exception) {
-        return become(reject(exception));
+        become(reject(exception));
     };
     deferred.notify = function (progress) {
         if (pending) {

diff --git a/spec/q-spec.js b/spec/q-spec.js
@@ -120,6 +120,11 @@ describe("defer and when", function () {
         return promise;
     });
 
+    it("returns `undefined` from the deferred's methods", function () {
+        expect(Q.defer().resolve()).toBe(undefined);
+        expect(Q.defer().reject()).toBe(undefined);
+    });
+
 });
 
 describe("always next tick", function () {