Skip to content

Commit

Permalink
* vm_insnhelper.c (vm_call_method): set ci->me to 0 when the
Browse files Browse the repository at this point in the history
  original method of a refined method is undef to avoid SEGV.

* vm_method.c (rb_method_entry_without_refinements): return 0 when
  the original method of a refined method is undef to avoid SEGV.

* test/ruby/test_refinement.rb: related test.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43334 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information
shugo committed Oct 17, 2013
1 parent 76b0655 commit f8e0e16
Show file tree
Hide file tree
Showing 4 changed files with 71 additions and 2 deletions.
10 changes: 10 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
Thu Oct 17 17:43:00 2013 Shugo Maeda <[email protected]>

* vm_insnhelper.c (vm_call_method): set ci->me to 0 when the
original method of a refined method is undef to avoid SEGV.

* vm_method.c (rb_method_entry_without_refinements): return 0 when
the original method of a refined method is undef to avoid SEGV.

* test/ruby/test_refinement.rb: related test.

Thu Oct 17 17:38:36 2013 Koichi Sasada <[email protected]>

* gc.c, internal.h: rename ruby_xsizefree/realloc to
Expand Down
48 changes: 48 additions & 0 deletions test/ruby/test_refinement.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1059,6 +1059,54 @@ class Object
INPUT
end

def test_refine_undefed_method_and_call
assert_in_out_err([], <<-INPUT, ["NoMethodError"], [])
class Foo
def foo
end
undef foo
end
module FooExt
refine Foo do
def foo
end
end
end
begin
Foo.new.foo
rescue => e
p e.class
end
INPUT
end

def test_refine_undefed_method_and_send
assert_in_out_err([], <<-INPUT, ["NoMethodError"], [])
class Foo
def foo
end
undef foo
end
module FooExt
refine Foo do
def foo
end
end
end
begin
Foo.new.send(:foo)
rescue => e
p e.class
end
INPUT
end

private

def eval_using(mod, s)
Expand Down
8 changes: 7 additions & 1 deletion vm_insnhelper.c
Original file line number Diff line number Diff line change
Expand Up @@ -1903,7 +1903,13 @@ vm_call_method(rb_thread_t *th, rb_control_frame_t *cfp, rb_call_info_t *ci)
no_refinement_dispatch:
if (ci->me->def->body.orig_me) {
ci->me = ci->me->def->body.orig_me;
goto normal_method_dispatch;
if (UNDEFINED_METHOD_ENTRY_P(ci->me)) {
ci->me = 0;
goto start_method_dispatch;
}
else {
goto normal_method_dispatch;
}
}
else {
klass = ci->me->klass;
Expand Down
7 changes: 6 additions & 1 deletion vm_method.c
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,12 @@ rb_method_entry_without_refinements(VALUE klass, ID id,
}
if (defined_class_ptr)
*defined_class_ptr = defined_class;
return me;
if (UNDEFINED_METHOD_ENTRY_P(me)) {
return 0;
}
else {
return me;
}
}

static void
Expand Down

0 comments on commit f8e0e16

Please sign in to comment.