Skip to content

Commit

Permalink
perf python: Cleanup useless double NULL termination in method arg names
Browse files Browse the repository at this point in the history
The list of methods argument names only needs to be NULL terminated
once. Remove the second ones.

Cc: David Ahern <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Cc: Tom Zanussi <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Frederic Weisbecker <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
fweisbec authored and acmel committed Jun 2, 2011
1 parent e95cc02 commit 6434815
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions tools/perf/util/python.c
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ struct pyrf_cpu_map {
static int pyrf_cpu_map__init(struct pyrf_cpu_map *pcpus,
PyObject *args, PyObject *kwargs)
{
static char *kwlist[] = { "cpustr", NULL, NULL, };
static char *kwlist[] = { "cpustr", NULL };
char *cpustr = NULL;

if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|s",
Expand Down Expand Up @@ -316,7 +316,7 @@ struct pyrf_thread_map {
static int pyrf_thread_map__init(struct pyrf_thread_map *pthreads,
PyObject *args, PyObject *kwargs)
{
static char *kwlist[] = { "pid", "tid", NULL, NULL, };
static char *kwlist[] = { "pid", "tid", NULL };
int pid = -1, tid = -1;

if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|ii",
Expand Down Expand Up @@ -418,7 +418,9 @@ static int pyrf_evsel__init(struct pyrf_evsel *pevsel,
"wakeup_events",
"bp_type",
"bp_addr",
"bp_len", NULL, NULL, };
"bp_len",
NULL
};
u64 sample_period = 0;
u32 disabled = 0,
inherit = 0,
Expand Down Expand Up @@ -499,7 +501,7 @@ static PyObject *pyrf_evsel__open(struct pyrf_evsel *pevsel,
struct thread_map *threads = NULL;
PyObject *pcpus = NULL, *pthreads = NULL;
int group = 0, inherit = 0;
static char *kwlist[] = {"cpus", "threads", "group", "inherit", NULL, NULL};
static char *kwlist[] = { "cpus", "threads", "group", "inherit", NULL };

if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OOii", kwlist,
&pcpus, &pthreads, &group, &inherit))
Expand Down Expand Up @@ -582,8 +584,7 @@ static PyObject *pyrf_evlist__mmap(struct pyrf_evlist *pevlist,
PyObject *args, PyObject *kwargs)
{
struct perf_evlist *evlist = &pevlist->evlist;
static char *kwlist[] = {"pages", "overwrite",
NULL, NULL};
static char *kwlist[] = { "pages", "overwrite", NULL };
int pages = 128, overwrite = false;

if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|ii", kwlist,
Expand All @@ -603,7 +604,7 @@ static PyObject *pyrf_evlist__poll(struct pyrf_evlist *pevlist,
PyObject *args, PyObject *kwargs)
{
struct perf_evlist *evlist = &pevlist->evlist;
static char *kwlist[] = {"timeout", NULL, NULL};
static char *kwlist[] = { "timeout", NULL };
int timeout = -1, n;

if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|i", kwlist, &timeout))
Expand Down Expand Up @@ -674,7 +675,7 @@ static PyObject *pyrf_evlist__read_on_cpu(struct pyrf_evlist *pevlist,
struct perf_evlist *evlist = &pevlist->evlist;
union perf_event *event;
int sample_id_all = 1, cpu;
static char *kwlist[] = {"cpu", "sample_id_all", NULL, NULL};
static char *kwlist[] = { "cpu", "sample_id_all", NULL };
int err;

if (!PyArg_ParseTupleAndKeywords(args, kwargs, "i|i", kwlist,
Expand Down

0 comments on commit 6434815

Please sign in to comment.