Skip to content

Commit

Permalink
[CRYPTO] cipher: Align temporary buffer in cbc_process_decrypt
Browse files Browse the repository at this point in the history
Since the temporary buffer is used as an argument to cia_decrypt, it must be
aligned by cra_alignmask.  This bug was found by [email protected].

Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
herbertx authored and David S. Miller committed Jan 9, 2006
1 parent fa9b98f commit 827c391
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions crypto/cipher.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,10 @@ static unsigned int cbc_process_decrypt(const struct cipher_desc *desc,
struct crypto_tfm *tfm = desc->tfm;
void (*xor)(u8 *, const u8 *) = tfm->crt_u.cipher.cit_xor_block;
int bsize = crypto_tfm_alg_blocksize(tfm);
unsigned long alignmask = crypto_tfm_alg_alignmask(desc->tfm);

u8 stack[src == dst ? bsize : 0];
u8 *buf = stack;
u8 stack[src == dst ? bsize + alignmask : 0];
u8 *buf = (u8 *)ALIGN((unsigned long)stack, alignmask + 1);
u8 **dst_p = src == dst ? &buf : &dst;

void (*fn)(void *, u8 *, const u8 *) = desc->crfn;
Expand Down

0 comments on commit 827c391

Please sign in to comment.