Skip to content

Commit

Permalink
[PATCH] USB: replace __setup("nousb") with __module_param_call
Browse files Browse the repository at this point in the history
Fedora users complain that passing "nousbstorage" to the installer causes
the rest of the USB support to disappear. The installer uses kernel command
line as a way to pass options through Syslinux. The problem stems from the
use of strncmp() in obsolete_checksetup().

I used __module_param_call() instead of module_param because I wanted to
preserve the old syntax in grub.conf, and it's the only macro which allows
to remove the prefix.

The fix is tested to accept the option "nousb" correctly now.

Signed-off-by: Pete Zaitcev <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Pete Zaitcev authored and gregkh committed Jan 4, 2006
1 parent 5e0f76c commit aafbf24
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions drivers/usb/core/usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
const char *usbcore_name = "usbcore";

static int nousb; /* Disable USB when built into kernel image */
/* Not honored on modular build */


/**
Expand Down Expand Up @@ -1096,18 +1095,8 @@ struct bus_type usb_bus_type = {
.resume = usb_generic_resume,
};

#ifndef MODULE

static int __init usb_setup_disable(char *str)
{
nousb = 1;
return 1;
}

/* format to disable USB on kernel command line is: nousb */
__setup("nousb", usb_setup_disable);

#endif
__module_param_call("", nousb, param_set_bool, param_get_bool, &nousb, 0444);

/*
* for external read access to <nousb>
Expand Down

0 comments on commit aafbf24

Please sign in to comment.