Skip to content

Commit

Permalink
pnfs-obj: No longer needed to take an extra ref at add_device
Browse files Browse the repository at this point in the history
Andy's last device_cache patches, already take an extra
reference on the newly inserted device_id. So we can remove it
from obj-io.

Without this patch the device_ids are leaked.

Andy's patches are not in Linus tree yet. So I'm not sure if they are
scheduled for this Kernel or the next. This patch should be added as
part of these.

CC: Andy Adamson <[email protected]>
Signed-off-by: Boaz Harrosh <[email protected]>
Signed-off-by: Trond Myklebust <[email protected]>
  • Loading branch information
Boaz Harrosh authored and Trond Myklebust committed Jun 19, 2011
1 parent 5afa913 commit df18d12
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/nfs/objlayout/objio_osd.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ _dev_list_add(const struct nfs_server *nfss,
de = n;
}

atomic_inc(&de->id_node.ref);
return de;
}

Expand Down

0 comments on commit df18d12

Please sign in to comment.