Skip to content

Commit

Permalink
Change all ActiveIssues to use Uris instead of numbers (dotnet#1768)
Browse files Browse the repository at this point in the history
  • Loading branch information
stephentoub authored Jan 16, 2020
1 parent 4ae8572 commit 04f2226
Show file tree
Hide file tree
Showing 257 changed files with 1,212 additions and 1,212 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public async Task WebSocketProtocol_CreateFromConnectedStream_CloseAsyncClosesSt
}
}

[ActiveIssue(36016)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/36016")]
[OuterLoop("Uses external servers")]
[Theory]
[MemberData(nameof(EchoServersAndBoolean))]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ public static void ImportNoModulus()

[Fact]
#if TESTING_CNG_IMPLEMENTATION
[ActiveIssue(18882, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/18882", TargetFrameworkMonikers.NetFramework)]
#endif
public static void ImportNoDP()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1340,7 +1340,7 @@ public static void FromInvalidXml()
}

[Fact]
[ActiveIssue(37595, TestPlatforms.OSX)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/37595", TestPlatforms.OSX)]
public static void FromNonsenseXml()
{
// This is DiminishedDPParameters XML, but with a P that is way too long.
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/Microsoft.CSharp/tests/AccessTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public void AccessNestedInternalOnlySameAssembly()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void AccessNestedPrivateProtectedAssembly()
{
dynamic d = Container.PrivateProtectedValueTypeArray();
Expand All @@ -272,7 +272,7 @@ public void AccessibleFields()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void InaccessibleFields()
{
dynamic d = new TypeWithFields();
Expand Down
10 changes: 5 additions & 5 deletions src/libraries/Microsoft.CSharp/tests/ArrayHandling.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace Microsoft.CSharp.RuntimeBinder.Tests
public class ArrayHandling
{
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void SingleRankNonSZArray()
{
dynamic d = Array.CreateInstance(typeof(int), new[] { 8 }, new[] { -2 });
Expand All @@ -23,7 +23,7 @@ public void SingleRankNonSZArray()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ArrayTypeNames()
{
dynamic d;
Expand All @@ -42,7 +42,7 @@ public void ArrayTypeNames()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void MultiDimArrayTypeNames()
{
dynamic d = new int[3, 2, 1];
Expand All @@ -58,7 +58,7 @@ public void MultiDimArrayTypeNames()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void IncorrectNumberOfIndices()
{
dynamic d = new int[2, 2, 2];
Expand Down Expand Up @@ -116,7 +116,7 @@ public void MDArrayLength()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void NonSZ1RArrayLenght()
{
dynamic d = Array.CreateInstance(typeof(int), new[] {23}, new[] {-2});
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.CSharp/tests/BindingErrors.cs
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ public void DoNothing()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void TryInvokeOrAccessNestedClassAsMember()
{
dynamic dFirst = new Outer.Inner();
Expand All @@ -456,7 +456,7 @@ public void TryInvokeOrAccessNestedClassAsMember()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void TryInvokeTypeParameterAsMember()
{
dynamic d = new List<int>();
Expand Down Expand Up @@ -485,7 +485,7 @@ public void DoNothing()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void AccessMethodHiddenByNested()
{
dynamic dFirst = new DerivedOuterHidingMethod.Inner();
Expand Down
20 changes: 10 additions & 10 deletions src/libraries/Microsoft.CSharp/tests/EnumArithmeticTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ public void EnumAddition(dynamic enumVal, dynamic integralVal, object expected)
}

[Theory, MemberData(nameof(ByteEnumAdditions))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void LiftedEnumAdditionByte(ByteEnum? enumVal, byte? integralVal, ByteEnum expected)
{
dynamic d = enumVal;
Expand All @@ -259,7 +259,7 @@ public void LiftedEnumAdditionByte(ByteEnum? enumVal, byte? integralVal, ByteEnu
}

[Theory, MemberData(nameof(SByteEnumAdditions))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void LiftedEnumAdditionSByte(SByteEnum? enumVal, sbyte? integralVal, SByteEnum expected)
{
dynamic d = enumVal;
Expand Down Expand Up @@ -428,7 +428,7 @@ public void CheckedEnumAddition(dynamic enumVal, dynamic integralVal, object exp
[MemberData(nameof(UInt32EnumSubtractions))]
[MemberData(nameof(Int64EnumSubtractions))]
[MemberData(nameof(UInt64EnumSubtractions))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void EnumSubtraction(dynamic enumVal, dynamic integralVal, object enMinusIn, object inMinusEn)
{
object result = unchecked(enumVal - integralVal);
Expand All @@ -440,7 +440,7 @@ public void EnumSubtraction(dynamic enumVal, dynamic integralVal, object enMinus
}

[Theory, MemberData(nameof(ByteEnumSubtractions))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void LiftedEnumSubtraction(ByteEnum? enumVal, byte? integralVal, ByteEnum? enMinusIn, ByteEnum? inMinusEn)
{
dynamic d = enumVal;
Expand All @@ -460,7 +460,7 @@ public void LiftedEnumSubtraction(ByteEnum? enumVal, byte? integralVal, ByteEnum
}

[Theory, MemberData(nameof(SByteEnumSubtractions))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void LiftedEnumSubtractionSByte(SByteEnum? enumVal, sbyte? integralVal, SByteEnum? enMinusIn, SByteEnum? inMinusEn)
{
dynamic d = enumVal;
Expand Down Expand Up @@ -594,7 +594,7 @@ public void LiftedEnumSubtractionUInt64(UInt64Enum? enumVal, ulong? integralVal,
}

[Theory, MemberData(nameof(ByteEnumSelfSubtraction))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void EnumSubtractionByte(ByteEnum? x, ByteEnum? y, byte expected, bool overflows)
{
dynamic d = x;
Expand All @@ -614,7 +614,7 @@ public void EnumSubtractionByte(ByteEnum? x, ByteEnum? y, byte expected, bool ov
}

[Theory, MemberData(nameof(SByteEnumSelfSubtraction))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void EnumSubtractionSByte(SByteEnum? x, SByteEnum? y, sbyte expected, bool overflows)
{
dynamic d = x;
Expand Down Expand Up @@ -756,7 +756,7 @@ public void EnumSubtractionUInt64(UInt64Enum? x, UInt64Enum? y, ulong expected,
[MemberData(nameof(UInt32EnumValueArguments))]
[MemberData(nameof(Int64EnumValueArguments))]
[MemberData(nameof(UInt64EnumValueArguments))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void WithLiteralNull(dynamic value)
{
object result = value + null;
Expand Down Expand Up @@ -788,7 +788,7 @@ public void WithNonLiteralNull(dynamic value)
}

[Theory, MemberData(nameof(ByteEnumValueArguments))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void WithTypedNullNullableByte(dynamic value)
{
object result = value + (byte?)null;
Expand All @@ -802,7 +802,7 @@ public void WithTypedNullNullableByte(dynamic value)
}

[Theory, MemberData(nameof(SByteEnumValueArguments))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void WithTypedNullNullableSByte(dynamic value)
{
object result = value + (sbyte?)null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public void CheckedEnumOnesComplement(dynamic operand, dynamic result)
[MemberData(nameof(Int32Enums))]
[MemberData(nameof(UInt32Enums))]
[MemberData(nameof(Int64Enums))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ConstantEnumOnesComplement(object operand, object result)
{
CallSite<Func<CallSite, object, object>> cs = CallSite<Func<CallSite, object, object>>.Create(
Expand All @@ -131,7 +131,7 @@ public void ConstantEnumOnesComplement(object operand, object result)
[MemberData(nameof(Int32Enums))]
[MemberData(nameof(UInt32Enums))]
[MemberData(nameof(Int64Enums))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ConstantCheckedEnumOnesComplement(object operand, object result)
{
CallSite<Func<CallSite, object, object>> cs = CallSite<Func<CallSite, object, object>>.Create(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ private struct ImplementingStruct : IInterface
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ClassInterfaceExplicitConversion()
{
AssertExplicitConvert(new SealedClass(), default(IInterface), ExpectedConversionResult.CompileError);
Expand Down Expand Up @@ -110,7 +110,7 @@ public void InterfaceClassExplicitConversion()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ClassInterfaceArrayElementExplicitConversions()
{
AssertExplicitConvert(new SealedClass[0], default(IInterface[]), ExpectedConversionResult.CompileError);
Expand All @@ -131,7 +131,7 @@ public void ClassInterfaceArrayElementExplicitConversionsCoreFX()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ClassInterfaceArrayIListElementExplicitConversions()
{
AssertExplicitConvert(new SealedClass[0], default(IList<IInterface>), ExpectedConversionResult.CompileError);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ public void StructToInterfacesAndBase()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ArraysToInterfaces()
{
int[] intArray = {1, 2, 3};
Expand Down
10 changes: 5 additions & 5 deletions src/libraries/Microsoft.CSharp/tests/IndexingTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ private class Implementation : IC
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void CustomIndexerName()
{
dynamic d = new AllTheIntegers();
Expand All @@ -53,7 +53,7 @@ public void CustomIndexerName()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void CustomIndexerNameDynamicArgument()
{
AllTheIntegers all = new AllTheIntegers();
Expand All @@ -72,7 +72,7 @@ public void TargetClassClaimsNonExistentMemberIsIndexer()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void DeepInheritingIndexingInterface()
{
IC ifaceTyped = new Implementation();
Expand Down Expand Up @@ -128,7 +128,7 @@ public IEnumerator<CSharpArgumentInfo> GetEnumerator()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void GetIndexWithNonRepeatingArgumentInfos()
{
CallSiteBinder binder = Binder.GetIndex(CSharpBinderFlags.None, GetType(), new ArgumentEnumerable(2));
Expand All @@ -140,7 +140,7 @@ public void GetIndexWithNonRepeatingArgumentInfos()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void SetIndexWithNonRepeatingArgumentInfos()
{
CallSiteBinder binder = Binder.SetIndex(CSharpBinderFlags.None, GetType(), new ArgumentEnumerable(3));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ public void RuntimeExpression(object x, object y, ExpressionType type, object re
[MemberData(nameof(UInt64TestMultiplications))]
[MemberData(nameof(UInt64TestNotEquals))]
[MemberData(nameof(UInt64TestSubtractions))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ConstantExpressions(object x, object y, ExpressionType type, object result, bool shouldSucceedChecked)
{
var callsite = GetBinaryOperationCallSite(type, false, true, true);
Expand Down Expand Up @@ -533,7 +533,7 @@ public void RuntimeDivideByZero(ExpressionType type, object x)
[MemberData(nameof(UInt32DivisionByZero))]
[MemberData(nameof(Int64DivisionByZero))]
[MemberData(nameof(UInt64DivisionByZero))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ConstantDivideByZero(ExpressionType type, object x)
{
var callsite = GetBinaryOperationCallSite(type, false, true, true);
Expand Down Expand Up @@ -609,7 +609,7 @@ public void ConstantModuloSignedMinimumByMinusOne(object dividend, object diviso
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void NullDMO()
{
BinaryOperationBinder binder = Binder.BinaryOperation(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public void RuntimeExpressions(object x, ExpressionType type, object result, boo
[MemberData(nameof(Int64TestOnesComplements))]
[MemberData(nameof(UInt64TestUnaryPluses))]
[MemberData(nameof(UInt64TestOnesComplements))]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void ConstantExpressions(object x, ExpressionType type, object result, bool shouldSucceedChecked)
{
var callsite = GetUnaryOperationCallSite(type, false, true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public void InnerExceptionCtor()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void InstanceArgumentInsteadOfTypeForStaticCall()
{
CallSite<Func<CallSite, object, object, object, object>> site =
Expand All @@ -62,7 +62,7 @@ public void InstanceArgumentInsteadOfTypeForStaticCall()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void InstanceArgumentInsteadOfTypeForStaticCallNamedArgument()
{
CallSite<Func<CallSite, object, object, object, object>> site =
Expand All @@ -80,7 +80,7 @@ public void InstanceArgumentInsteadOfTypeForStaticCallNamedArgument()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void NullArgumentInsteadOfTypeForStaticCallNamedArgument()
{
CallSite<Func<CallSite, object, object, object, object>> site =
Expand All @@ -98,7 +98,7 @@ public void NullArgumentInsteadOfTypeForStaticCallNamedArgument()
}

[Fact]
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public void NonTypeToCtor()
{
CallSite<Func<CallSite, object, object>> site = CallSite<Func<CallSite, object, object>>.Create(
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.CSharp/tests/RuntimeBinderTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

namespace Microsoft.CSharp.RuntimeBinder.Tests
{
[ActiveIssue(31032, TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/corefx/issues/31032", TargetFrameworkMonikers.NetFramework)]
public class RuntimeBinderTests
{
[Fact]
Expand Down
Loading

0 comments on commit 04f2226

Please sign in to comment.