Comment on why s_createProcessLock exists in Process.Windows.cs (dotn…

…et#838)
temfordump · Dec 13, 2019 · 936f947 · 936f947
1 parent 8c878a0
commit 936f947
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs b/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs
@@ -476,6 +476,10 @@ private unsafe bool StartWithCreateProcess(ProcessStartInfo startInfo)
             SafeFileHandle parentErrorPipeHandle = null;
             SafeFileHandle childErrorPipeHandle = null;
 
+            // Take a global lock to synchronize all redirect pipe handle creations and CreateProcess
+            // calls. We do not want one process to inherit the handles created concurrently for another
+            // process, as that will impact the ownership and lifetimes of those handles now inherited
+            // into multiple child processes.
             lock (s_createProcessLock)
             {
                 try