address feedback

Commit migrated from dotnet/corefx@8f051b2
temfordump · Mar 25, 2019 · 9c81da6 · 9c81da6
1 parent dfeef6e
commit 9c81da6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlCommand.cs b/src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlCommand.cs
@@ -3295,8 +3295,7 @@ private void GetRPCObject(int systemParamCount, int userParamCount, ref _SqlRPC
             }
         }
 
-
-        private void SetUpRPCParameters(_SqlRPC rpc, int startCount, bool inSchema, SqlParameterCollection parameters)
+        private void SetUpRPCParameters(_SqlRPC rpc, bool inSchema, SqlParameterCollection parameters)
         {
             int paramCount = GetParameterCount(parameters);
             int userParamCount = 0;
@@ -3399,7 +3398,7 @@ private _SqlRPC BuildPrepExec(CommandBehavior behavior)
             sqlParam.Size = text.Length;
             sqlParam.Value = text;
 
-            SetUpRPCParameters(rpc, systemParameterCount, false, _parameters);
+            SetUpRPCParameters(rpc, false, _parameters);
 
             return rpc;
         }
@@ -3461,7 +3460,7 @@ private void BuildRPC(bool inSchema, SqlParameterCollection parameters, ref _Sql
             rpc.ProcID = 0;
             rpc.rpcName = this.CommandText; // just get the raw command text
 
-            SetUpRPCParameters(rpc, 0, inSchema, parameters);
+            SetUpRPCParameters(rpc, inSchema, parameters);
         }
 
         //
@@ -3494,7 +3493,7 @@ private _SqlRPC BuildExecute(bool inSchema)
             sqlParam.Value = _prepareHandle;
             sqlParam.Direction = ParameterDirection.Input;
 
-            SetUpRPCParameters(rpc, systemParameterCount, inSchema, _parameters);
+            SetUpRPCParameters(rpc, inSchema, _parameters);
             return rpc;
         }
 
@@ -3546,7 +3545,7 @@ private void BuildExecuteSql(CommandBehavior behavior, string commandText, SqlPa
                 sqlParam.Value = paramList;
 
                 bool inSchema = (0 != (behavior & CommandBehavior.SchemaOnly));
-                SetUpRPCParameters(rpc, systemParamCount, inSchema, parameters);
+                SetUpRPCParameters(rpc, inSchema, parameters);
             }
         }
 

diff --git a/src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/TdsParserHelperClasses.cs b/src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/TdsParserHelperClasses.cs
@@ -678,7 +678,7 @@ sealed internal class _SqlRPC
         internal int warningsIndexEnd;
         internal SqlErrorCollection warnings;
 
-        public SqlParameter GetParameterByIndex(int index, out byte options)
+        internal SqlParameter GetParameterByIndex(int index, out byte options)
         {
             options = 0;
             SqlParameter retval = null;