no-implicit-dependencies should include peer dependencies even with "…

…dev" option set (palantir#3875)
temporaryAny · Jun 26, 2018 · 6989dd7 · 6989dd7
1 parent 1c31dc0
commit 6989dd7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/rules/noImplicitDependenciesRule.ts b/src/rules/noImplicitDependenciesRule.ts
@@ -41,7 +41,7 @@ export class Rule extends Lint.Rules.AbstractRule {
         `,
         optionsDescription: Lint.Utils.dedent`
             By default the rule looks at \`"dependencies"\` and \`"peerDependencies"\`.
-            By adding the \`"${OPTION_DEV}"\` option the rule looks at \`"devDependencies"\` instead of \`"peerDependencies"\`.
+            By adding the \`"${OPTION_DEV}"\` option the rule also looks at \`"devDependencies"\`.
             By adding the \`"${OPTION_OPTIONAL}"\` option the rule also looks at \`"optionalDependencies"\`.
         `,
         options: {
@@ -121,7 +121,7 @@ function getDependencies(fileName: string, options: Options): Set<string> {
             if (content.dependencies !== undefined) {
                 addDependencies(result, content.dependencies);
             }
-            if (!options.dev && content.peerDependencies !== undefined) {
+            if (content.peerDependencies !== undefined) {
                 addDependencies(result, content.peerDependencies);
             }
             if (options.dev && content.devDependencies !== undefined) {

diff --git a/test/rules/no-implicit-dependencies/dev/test.ts.lint b/test/rules/no-implicit-dependencies/dev/test.ts.lint
@@ -1,5 +1,4 @@
 import * as ts from 'typescript';
-                    ~~~~~~~~~~~~ [err % ('typescript')]
 
 import {assert} from 'chai';