no-unbound-method: Allow use as condition (palantir#2834)

temporaryAny · May 30, 2017 · 8ea3c35 · 8ea3c35
1 parent f9113e9
commit 8ea3c35
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/rules/noUnboundMethodRule.ts b/src/rules/noUnboundMethodRule.ts
@@ -87,6 +87,14 @@ function isSafeUse(node: ts.Node): boolean {
         // Allow most binary operators, but don't allow e.g. `myArray.forEach(obj.method || otherObj.otherMethod)`.
         case ts.SyntaxKind.BinaryExpression:
             return (parent as ts.BinaryExpression).operatorToken.kind !== ts.SyntaxKind.BarBarToken;
+        // Allow use in conditions
+        case ts.SyntaxKind.ConditionalExpression:
+            return (parent as ts.ConditionalExpression).condition === node;
+        case ts.SyntaxKind.IfStatement:
+        case ts.SyntaxKind.WhileStatement:
+        case ts.SyntaxKind.DoStatement:
+        case ts.SyntaxKind.ForStatement:
+            return true;
         default:
             return false;
     }

diff --git a/test/rules/no-unbound-method/default/test.tsx.lint b/test/rules/no-unbound-method/default/test.tsx.lint
@@ -26,6 +26,18 @@ i.foo;
 i.bar;
 
 c.method === i.foo;
+
+// OK in condition
+c.method ? 1 : 2;
+1 ? c.method : c.method;
+    ~~~~~~~~ [0]
+               ~~~~~~~~ [0]
+if (c.method) {}
+while (c.method) {}
+do () while (c.method);
+for (c.method; c.method; c.method) {}
+
+
 [0].forEach(c.method || i.foo);
             ~~~~~~~~ [0]
                         ~~~~~ [0]