Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scrollbar issue with update the screen with grid structure #59

Closed
wants to merge 10 commits into from

Conversation

fromancient
Copy link

#57

Fix this scrollbar issue and update the page with grid structure for more secure page structure

… responsive

Co-Authored-By: Cameron Fairchild <[email protected]>
Co-Authored-By: 10-ET | TCL <[email protected]>
Copy link

vercel bot commented Jan 30, 2025

@fromancient is attempting to deploy a commit to the cdl Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
secure-sign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 1:15pm

Copy link
Contributor

@10-ET 10-ET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using constant values like 180px will not make pages responsive on several devices
here's an example: (top, bottom spacing not identical)
image

Co-Authored-By: Cameron Fairchild <[email protected]>
Co-Authored-By: 10-ET | TCL <[email protected]>
@fromancient
Copy link
Author

I've updated the PR again. I've removed the hardcoded width and tested it on different screen heights.

Copy link
Contributor

@10-ET 10-ET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

Co-Authored-By: Cameron Fairchild <[email protected]>
Co-Authored-By: 10-ET | TCL <[email protected]>
@fromancient fromancient requested a review from 10-ET January 30, 2025 16:32
@fromancient
Copy link
Author

removed the hard-coded part and finally updated!

Co-Authored-By: Cameron Fairchild <[email protected]>
Co-Authored-By: 10-ET | TCL <[email protected]>
@fromancient
Copy link
Author

request updated

Co-Authored-By: Cameron Fairchild <[email protected]>
Co-Authored-By: 10-ET | TCL <[email protected]>
Copy link
Contributor

@10-ET 10-ET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you migrated from flex to grid for the whole app, but i find some problems, (left comments on discord)

@fromancient
Copy link
Author

updated based on your feedback

Co-Authored-By: 10-ET | TCL <[email protected]>
@10-ET
Copy link
Contributor

10-ET commented Feb 25, 2025

closing this PR due to inactivity for the past 2 weeks @fromancient
thanks for your contribution

@10-ET 10-ET closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants