-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix scrollbar issue with update the screen with grid structure #59
Conversation
… responsive Co-Authored-By: Cameron Fairchild <[email protected]> Co-Authored-By: 10-ET | TCL <[email protected]>
@fromancient is attempting to deploy a commit to the cdl Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Cameron Fairchild <[email protected]> Co-Authored-By: 10-ET | TCL <[email protected]>
I've updated the PR again. I've removed the hardcoded width and tested it on different screen heights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Cameron Fairchild <[email protected]> Co-Authored-By: 10-ET | TCL <[email protected]>
removed the hard-coded part and finally updated! |
Co-Authored-By: Cameron Fairchild <[email protected]> Co-Authored-By: 10-ET | TCL <[email protected]>
request updated |
Co-Authored-By: Cameron Fairchild <[email protected]> Co-Authored-By: 10-ET | TCL <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you migrated from flex to grid for the whole app, but i find some problems, (left comments on discord)
Co-Authored-By: 10-ET | TCL <[email protected]>
updated based on your feedback |
Co-Authored-By: 10-ET | TCL <[email protected]>
Co-Authored-By: 10-ET | TCL <[email protected]>
Co-Authored-By: 10-ET | TCL <[email protected]> Co-Authored-By: CDL <[email protected]>
closing this PR due to inactivity for the past 2 weeks @fromancient |
#57
Fix this scrollbar issue and update the page with grid structure for more secure page structure