[tfjs-layers] fix reshape layer output shape computation #2719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that output shape is computed correctly when input shape has an unknown batch size.
In Keras, a Reshape layer with
batch_input_shape=[None, 16]
andtarget_shape=[-1, 1]
has output shape[None, 16, 1]
as the reshape operation is being applied per batch.In TFJS an equivalent Reshape layer would have an output shape
[None, None, 1]
thus adding an unnecessary unknown dimension. Plus this behavior was not consistent with the python implementation.This change is