LightMetal - Initial Replay infra/library for LightMetalBinary and standalone runner (#17039) #17524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmabeeTT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema,
cfjchu and
omilyutin-tt
as code owners
kmabeeTT
force-pushed
the
kmabee/light_metal_capture_and_tests
branch
from
79be348 to
50da601
Compare
kmabeeTT
force-pushed
the
kmabee/light_metal_capture_and_tests
branch
from
50da601 to
9b56336
Compare
omilyutin-tt
requested changes
Feb 5, 2025
kmabeeTT
force-pushed
the
kmabee/light_metal_replay_and_runner
branch
from
2d0cf2f to
fa33198
Compare
kmabeeTT
force-pushed
the
kmabee/light_metal_capture_and_tests
branch
2 times, most recently
from
b936169 to
bea47ea
Compare
kmabeeTT
force-pushed
the
kmabee/light_metal_replay_and_runner
branch
from
fa33198 to
8770752
Compare
…andalone runner (#17039) - This is round 6/6 for now, builds upon previous 5 merges for LightMetal in past week and enables e2e capture + replay in unit tests now that replay is supported. - This brings the replay library/executor for a LightMetalBinary which handles replaying all the commands and traces captured by workload to binary. Like capture time, complex objects are stored in map after creation, and referenced by global_id by functions that re-use them. - Light Metal standalone CLI runner initial infra which just loads an existing binary on disk and executes it using replay librarys's ExecuteLightMetalBinary() - Some PR Reedback: Update asserts, remove default cases, more comments, etc.
kmabeeTT
force-pushed
the
kmabee/light_metal_replay_and_runner
branch
from
8770752 to
7a6efdc
Compare
|
Tag @omilyutin-tt for re-review please. Rebased on latest, resolved all conversations, fixup into single commit and force pushed. Checking build and tests pass locally (Edit: Yes) and would merge after approved. Edit2: Also rerun code-analysis and all-build-configs (passed). |
omilyutin-tt
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
I am breaking up original PR I put up recently into smaller bite-sized chunks as @omilyutin-tt suggested. Here is round 6.
Note: This builds on round 5 PR (#17514) I opened earlier today, but since the changes were ~minimal, ready and cleaned up, I opened this Round 6 now. Set target branch as previous PR branch to reduce diff until it's merged, then will adjust to target main.
Problem description
This is initial/bootstrapping changes for "Light Metal" capture/replay feature that uses Flatbuffers as serialization/deserialization library. See my previous bigger PR (#16573) if you want to see how this will be used by followup merge, or context.
What's changed
Incorporates bunch of feedback in big original parent PR.
Checklist