Automatically generate an overload w/o QueueId #17640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayerofieiev-tt
requested review from
patrickroberts,
sjameelTT,
ntarafdar,
dchenTT,
SeanNijjar,
cfjchu,
jvegaTT,
tt-aho,
dmakoviichuk-tt and
TT-BrianLiu
as code owners
ayerofieiev-tt
commented
Feb 6, 2025
ayerofieiev-tt
requested review from
bbradelTT,
vsureshTT,
jaykru-tt,
yugi957,
llongTT and
nardoTT
as code owners
omilyutin-tt
approved these changes
Feb 6, 2025
ntarafdar
approved these changes
Feb 6, 2025
bbradelTT
approved these changes
Feb 6, 2025
mywoodstock
approved these changes
Feb 6, 2025
SeanNijjar
approved these changes
Feb 6, 2025
ayerofieiev-tt
requested review from
a team,
esmalTT,
uaydonat,
razorback3,
dongjin-na,
rtawfik01,
ttmtrajkovic,
rdjogoTT,
aliuTT,
ubcheema,
aagarwalTT,
abhullar-tt,
pgkeller,
tt-dma,
tt-asaigal and
davorchap
as code owners
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#10605
Problem description
This is an experiment aimed to reduce amount of code OP developers write.
What's changed
If an OP provides
::invokewhich accepts QueueId as the first argument, decorator of a registered operation will handle invokes whenqueue_idis not provided by passing in theDefaultQueueId.While a reduction in code, it comes at a cost of compilation time.
Besides that, the idea of passing queue_id into ops in this way is not something that I want to support.
This PR is opened to facilitate a conversation.
Checklist