Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dockerfile #2044

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

daviddhc20120601
Copy link

@daviddhc20120601 daviddhc20120601 commented Jan 2, 2025

Create Dockerfile

What is the change?

created a dockerfile

Why is the change being made?

make the install and deploy faster

close #2043


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

Create Dockerfile
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2025

CLA assistant check
All committers have signed the CLA.

RUN pip install --upgrade pip
RUN pip install -e ".[test]"

RUN pip install ruamel.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is here, that is already an ARMI dependency.

As proof, see the ARMI unit tests running under GitHub CI.

@@ -0,0 +1,15 @@
# Use an official Python runtime as a parent image
FROM python:3.11-slim
LABEL authors="daviddhc20120601"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

@john-science john-science added the feature request Smaller user request label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is there a dockerized deployed plan?
3 participants