Change target_link_libraries to PUBLIC

terrencetao · Sep 25, 2020 · a900efa · a900efa
1 parent 689a25a
commit a900efa
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/lm/CMakeLists.txt b/lm/CMakeLists.txt
@@ -32,7 +32,7 @@ add_subdirectory(common)
 
 add_library(kenlm ${KENLM_LM_SOURCE} ${KENLM_LM_COMMON_SOURCE})
 set_target_properties(kenlm PROPERTIES POSITION_INDEPENDENT_CODE ON)
-target_link_libraries(kenlm kenlm_util ${Boost_LIBRARIES} Threads::Threads)
+target_link_libraries(kenlm PUBLIC kenlm_util ${Boost_LIBRARIES} Threads::Threads)
 
 set(KENLM_MAX_ORDER 6 CACHE STRING "Maximum supported ngram order")
 target_compile_definitions(kenlm PUBLIC -DKENLM_MAX_ORDER=${KENLM_MAX_ORDER})

diff --git a/lm/builder/CMakeLists.txt b/lm/builder/CMakeLists.txt
@@ -28,7 +28,7 @@ set(KENLM_BUILDER_SOURCE
 #
 add_library(kenlm_builder ${KENLM_BUILDER_SOURCE})
 
-target_link_libraries(kenlm_builder kenlm kenlm_util ${Boost_LIBRARIES} Threads::Threads)
+target_link_libraries(kenlm_builder PUBLIC kenlm kenlm_util ${Boost_LIBRARIES} Threads::Threads)
 
 AddExes(EXES lmplz
         LIBRARIES kenlm_builder kenlm kenlm_util ${Boost_LIBRARIES} Threads::Threads)

diff --git a/lm/filter/CMakeLists.txt b/lm/filter/CMakeLists.txt
@@ -23,7 +23,7 @@ set(KENLM_FILTER_SOURCE
 # refer to these objects as $<TARGET_OBJECTS:foo>
 #
 add_library(kenlm_filter ${KENLM_FILTER_SOURCE})
-target_link_libraries(kenlm_filter kenlm_util)
+target_link_libraries(kenlm_filter PUBLIC kenlm_util)
 
 AddExes(EXES filter phrase_table_vocab
         LIBRARIES kenlm_filter kenlm)

diff --git a/lm/interpolate/CMakeLists.txt b/lm/interpolate/CMakeLists.txt
@@ -26,7 +26,7 @@ if(EIGEN3_FOUND)
     endif()
 
     add_library(kenlm_interpolate ${KENLM_INTERPOLATE_SOURCE})
-    target_link_libraries(kenlm_interpolate kenlm)
+    target_link_libraries(kenlm_interpolate PUBLIC kenlm)
 
     set(KENLM_INTERPOLATE_EXES
         interpolate

diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
@@ -12,9 +12,9 @@ elseif(WIN32)
   set_target_properties(kenlm_python PROPERTIES SUFFIX ".pyd")
 endif()
 
-target_link_libraries(kenlm_python kenlm)
+target_link_libraries(kenlm_python PUBLIC kenlm)
 if(WIN32)
-  target_link_libraries(kenlm_python ${PYTHON_LIBRARIES})
+  target_link_libraries(kenlm_python PUBLIC ${PYTHON_LIBRARIES})
 elseif(APPLE)
   set_target_properties(kenlm_python PROPERTIES LINK_FLAGS "-undefined dynamic_lookup")
 endif()

diff --git a/util/CMakeLists.txt b/util/CMakeLists.txt
@@ -64,7 +64,7 @@ endif()
 # Group these objects together for later use.
 add_library(kenlm_util ${KENLM_UTIL_DOUBLECONVERSION_SOURCE} ${KENLM_UTIL_STREAM_SOURCE} ${KENLM_UTIL_SOURCE})
 set_target_properties(kenlm_util PROPERTIES POSITION_INDEPENDENT_CODE ON)
-target_link_libraries(kenlm_util ${Boost_LIBRARIES} ${READ_COMPRESSED_LIBS} Threads::Threads ${RT})
+target_link_libraries(kenlm_util PUBLIC ${Boost_LIBRARIES} ${READ_COMPRESSED_LIBS} Threads::Threads ${RT})
 
 AddExes(EXES probing_hash_table_benchmark
         LIBRARIES kenlm_util ${Boost_LIBRARIES} Threads::Threads)