[flatpickr] Fix DefinitelyTyped#20701: Deprecate redundant "flatpickr…

…" types (DefinitelyTyped#20983) * Cut: Run "not-needed" script. * Cut: .github/CODEOWNERS entries. * Fix: "react-flatpickr" definition file and tests.
terski · Oct 25, 2017 · a374bea · a374bea
1 parent 302690e
commit a374bea
Show file tree

Hide file tree

Showing 13 changed files with 16 additions and 262 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -931,8 +931,6 @@
 /types/first-mate/                                       @GlenCFL
 /types/fixed-data-table/                                 @pepaar @stephenjelfs
 /types/flat/                                             @chrootsu
-/types/flatpickr/v2/                                     @UnwrittenFun
-/types/flatpickr/                                        @UnwrittenFun @rowellx68 @wagich
 /types/flexslider/                                       @diullei
 /types/flickity/                                         @clmcgrath @wagich
 /types/flight/                                           @jonathanhedren

diff --git a/notNeededPackages.json b/notNeededPackages.json
@@ -216,6 +216,12 @@
             "sourceRepoURL": "http://fineuploader.com/",
             "asOfVersion": "5.14.0"
         },
+        {
+            "libraryName": "flatpickr",
+            "typingsPackageName": "flatpickr",
+            "sourceRepoURL": "https://github.com/chmln/flatpickr",
+            "asOfVersion": "3.1.2"
+        },
         {
             "libraryName": "gaea-model",
             "typingsPackageName": "gaea-model",

diff --git a/types/flatpickr/flatpickr-tests.ts b/types/flatpickr/flatpickr-tests.ts
diff --git a/types/flatpickr/index.d.ts b/types/flatpickr/index.d.ts
diff --git a/types/flatpickr/tsconfig.json b/types/flatpickr/tsconfig.json
diff --git a/types/flatpickr/tslint.json b/types/flatpickr/tslint.json
diff --git a/types/flatpickr/v2/flatpickr-tests.ts b/types/flatpickr/v2/flatpickr-tests.ts
diff --git a/types/flatpickr/v2/index.d.ts b/types/flatpickr/v2/index.d.ts
diff --git a/types/flatpickr/v2/tsconfig.json b/types/flatpickr/v2/tsconfig.json
diff --git a/types/flatpickr/v2/tslint.json b/types/flatpickr/v2/tslint.json
diff --git a/types/react-flatpickr/index.d.ts b/types/react-flatpickr/index.d.ts
@@ -5,12 +5,12 @@
 // TypeScript Version: 2.3
 
 import { Component } from 'react';
-import { EventCallback, Options } from 'flatpickr';
+import { Hook, Options } from 'flatpickr';
 
 export interface DateTimePickerProps {
     defaultValue?: string;
     options?: Options;
-    onChange?: EventCallback;
+    onChange?: Hook;
     value?: string;
 }
 

diff --git a/types/react-flatpickr/package.json b/types/react-flatpickr/package.json
@@ -0,0 +1,6 @@
+{
+    "private": true,
+    "dependencies": {
+        "flatpickr": "^4.0.6"
+    }
+}
diff --git a/types/react-flatpickr/react-flatpickr-tests.tsx b/types/react-flatpickr/react-flatpickr-tests.tsx
@@ -1,4 +1,4 @@
-import * as Flatpickr from 'flatpickr';
+import { Instance } from 'flatpickr';
 import * as React from 'react';
 import DatePicker from 'react-flatpickr';
 
@@ -12,7 +12,7 @@ const options = {
 const optionsElement = <DatePicker options={ options }/>;
 
 const onChange = (
-    selectedDates: Date[], dateStr: string, instance: Flatpickr,
+    selectedDates: Date[], dateStr: string, instance: Instance,
     elem: HTMLElement
 ) => null;
 const onChangeElement = <DatePicker onChange={ onChange }/>;