Skip to content

Commit

Permalink
Extend "dtslint/dt.json" directly instead of "../tslint.json". (Defin…
Browse files Browse the repository at this point in the history
…itelyTyped#15822)

* Extend "dtslint/dt.json" directly instead of "../tslint.json".

* Convert more "../tslint.json" to "dtslint/dt.json"

* no-redundant-modifiers -> strict-export-declare-modifiers
  • Loading branch information
Andy authored Apr 14, 2017
1 parent 460be51 commit bbc61fb
Show file tree
Hide file tree
Showing 817 changed files with 854 additions and 861 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ If adding a new definition:
If changing an existing definition:
- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
- [ ] Increase the version number in the header if appropriate.
- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "../tslint.json" }`.
- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "dslint/dt.json" }`.

If removing a declaration:
- [ ] If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,12 @@ If a package was never on DefinitelyTyped, it does not need to be added to `notN

#### Lint

To lint a package, just add a `tslint.json` to that package containing `{ "extends": "../tslint.json" }`. All new packages must be linted.
To lint a package, just add a `tslint.json` to that package containing `{ "extends": "dtslint/dt.json" }`. All new packages must be linted.
If a `tslint.json` turns rules off, this is because that hasn't been fixed yet. For example:

```js
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
// This package uses the Function type, and it will take effort to fix.
"forbidden-types": false
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"compile-scripts": "tsc -p scripts",
"not-needed": "node scripts/not-needed.js",
"test": "node node_modules/types-publisher/bin/tester/test.js --run-from-definitely-typed --nProcesses 1",
"lint": "dtslint --dt types"
"lint": "dtslint types"
},
"devDependencies": {
"dtslint": "Microsoft/dtslint#production",
Expand Down
2 changes: 1 addition & 1 deletion scripts/fix-tslint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function fixTslint(dir: string): void {
if (!fs.existsSync(target)) return;
let json = JSON.parse(fs.readFileSync(target, 'utf-8'));
json = fix(json);
const text = Object.keys(json).length === 1 ? '{ "extends": "../tslint.json" }' : JSON.stringify(json, undefined, 4);
const text = Object.keys(json).length === 1 ? '{ "extends": "dtslint/dt.json" }' : JSON.stringify(json, undefined, 4);
fs.writeFileSync(target, text + "\n", "utf-8");
}

Expand Down
2 changes: 1 addition & 1 deletion types/ably/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/abs/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/accepts/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/accounting/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/algebra.js/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/amplify-deferred/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"ban-types": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/amplify/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"ban-types": false,
"unified-signatures": false
Expand Down
2 changes: 1 addition & 1 deletion types/amqplib/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"no-empty-interface": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/angular-gridster/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/angular-oauth2/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/angular/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"class-name": true,
"indent": [true, "spaces"],
Expand Down
2 changes: 1 addition & 1 deletion types/apex.js/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/applepayjs/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
4 changes: 2 additions & 2 deletions types/applicationinsights-js/tslint.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"interface-name": [ false ],
"no-internal-module": false,
"no-single-declare-module": false
}
}
}
2 changes: 1 addition & 1 deletion types/arcgis-rest-api/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/arcgis-to-geojson-utils/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/array-find-index/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/array-uniq/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/artyom.js/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/assert-plus/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/aurelia-knockout/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/autoprefixer/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/awesomplete/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
4 changes: 2 additions & 2 deletions types/aws-lambda-mock-context/tslint.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "../tslint.json"
}
"extends": "dtslint/dt.json"
}
2 changes: 1 addition & 1 deletion types/aws-serverless-express/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/b_/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/babel-code-frame/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/base-64/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/base64-js/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/bigi/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/bignumber.js/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/bitcoinjs-lib/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/bittorrent-protocol/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"no-misused-new": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/blacklist/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/bloomfilter/tslint.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "../tslint.json"
"extends": "dtslint/dt.json"
}
2 changes: 1 addition & 1 deletion types/bluebird-global/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"max-line-length": false,
"no-empty-interface": false,
Expand Down
2 changes: 1 addition & 1 deletion types/body-parser/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"max-line-length": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/bootstrap-validator/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
4 changes: 2 additions & 2 deletions types/bootstrap.v3.datetimepicker/tslint.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"quotemark": [true, "double", "avoid-escape"]
}
}
}
2 changes: 1 addition & 1 deletion types/browser-bunyan/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/browser-fingerprint/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/bufferstream/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/bunyan-blackhole/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/camelcase-keys/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/chai-json-schema/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/chai-oequal/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"no-single-declare-module": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/chai-subset/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/chai-xml/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/charm/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"ban-types": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/checkstyle-formatter/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/chunked-dc/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/clamp-js/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/clipboard/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/clndr/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/co-views/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"ban-types": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/code/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/codependency/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/coinstring/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/colors/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/combined-stream/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/comment-json/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
4 changes: 2 additions & 2 deletions types/compression-webpack-plugin/tslint.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"extends": "../tslint.json"
"extends": "dtslint/dt.json"
}


2 changes: 1 addition & 1 deletion types/concat-stream/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/conf/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/configstore/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/connect-ensure-login/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/content-disposition/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/convert-source-map/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/cookie-signature/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/cookies/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/cordova-sqlite-storage/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/core-decorators/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"callable-types": false,
"ban-types": false
Expand Down
4 changes: 2 additions & 2 deletions types/core-js/tslint.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"ban-types": false
}
}
}
2 changes: 1 addition & 1 deletion types/cpy/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/crc/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/croppie/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/csprng/tslint.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "../tslint.json"
"extends": "dtslint/dt.json"
}
2 changes: 1 addition & 1 deletion types/csrf/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/csv-parse/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"no-empty-interface": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/csv-stringify/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/csvtojson/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"ban-types": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/currency-formatter/tslint.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "extends": "../tslint.json" }
{ "extends": "dtslint/dt.json" }
2 changes: 1 addition & 1 deletion types/d3-array/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"unified-signatures": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/d3-axis/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"unified-signatures": false
}
Expand Down
2 changes: 1 addition & 1 deletion types/d3-brush/tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../tslint.json",
"extends": "dtslint/dt.json",
"rules": {
"unified-signatures": false
}
Expand Down
Loading

0 comments on commit bbc61fb

Please sign in to comment.