Update docs #4541
Closed
Update docs #4541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jheredianet
commented
Feb 14, 2025
jheredianet
commented
- Add script for maintenance: REINDEX
- Rearrange Projects using TeslaMate as DataSource, removing outdated projects or those that don't really use Teslamate as datasource and order by name
- Minor fixes in docs for Website
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brianmay
requested changes
Feb 16, 2025
| # Magic Nix Cache has been deprecated due to a change in the underlying GitHub APIs and will stop working on 1 February 2025. | ||
| # To continue caching Nix builds in GitHub Actions, use FlakeHub Cache instead. | ||
| #uses: DeterminateSystems/magic-nix-cache-action@6221693898146dc97e38ad0e013488a16477a4c4 #v9 | ||
| uses: DeterminateSystems/flakehub-cache-action@6221693898146dc97e38ad0e013488a16477a4c4 #v9 |
There was a problem hiding this comment.
I think this change really deserves a pull request all of its own. Something like that can get lost if combined with unrelated changes. And it looks somewhat important.
Where can I find this change documented? I tried looking https://github.com/DeterminateSystems/magic-nix-cache-action but I don't see anything.
Did you forget to update the hash? Seems kind of suspect that the hash is exactly the same.
JakobLichterfeld
requested changes
Feb 17, 2025
|
As the PR is not only a doc change this PR will be closed, as it is highly misleading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.