Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting correct hostname using hostnamectl also #129

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Conversation

baelish
Copy link
Collaborator

@baelish baelish commented Oct 29, 2018

Sometimes for reasons unknown to me a "transient" name was set in hostnamectl and this causes a fight between systemd-resolved and other things trying to set the hostname, as systemd runs many things in parallel it depends which thing runs last to find which hostname you end up with. The addition here will set the hostname using hostnamectl if the command is in the path and it reports either it's static or transient name as different from desired.

Sometimes for reasons unknown to me a "transient" name was set in hostnamectl and this causes a fight between systemd-resolved and other things trying to set the hostname, as systemd runs many things in parallel it depends which thing runs last to find which hostname you end up with. The addition here will set the hostname using hostnamectl if the command is in the path and it reports either it's static or transient name as different from desired.
@baelish baelish requested a review from fidian October 29, 2018 16:17
@baelish
Copy link
Collaborator Author

baelish commented Oct 29, 2018

@fidian Sorry, it seems I fall from one thing into another. Looks like this may be the final one 🤞

@fidian
Copy link
Contributor

fidian commented Oct 29, 2018

I don't mind, especially since you are helping out the project with each commit!

@fidian fidian merged commit b492cc2 into master Oct 29, 2018
@baelish baelish deleted the fix/set-hostname branch October 29, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants