Less verbose for the linter

texascanadasean · Oct 27, 2015 · 8e317d4 · 8e317d4
1 parent ea4c449
commit 8e317d4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/jasmine-core/jasmine.js b/lib/jasmine-core/jasmine.js
@@ -1992,7 +1992,13 @@ getJasmineRequireObj().SpyRegistry = function(j$) {
         throw new Error(methodName + ' has already been spied upon');
       }
 
-      var descriptor = Object.getOwnPropertyDescriptor(obj, methodName);
+      var descriptor;
+      try {
+        descriptor = Object.getOwnPropertyDescriptor(obj, methodName);
+      } catch(e) {
+        // IE 8 doesn't support `definePropery` on non-DOM nodes
+      }
+
       if (descriptor && !(descriptor.writable || descriptor.set)) {
         throw new Error(methodName + ' is not declared writable or has no setter');
       }

diff --git a/src/core/SpyRegistry.js b/src/core/SpyRegistry.js
@@ -22,7 +22,7 @@ getJasmineRequireObj().SpyRegistry = function(j$) {
         throw new Error(methodName + ' has already been spied upon');
       }
 
-      var descriptor = undefined;
+      var descriptor;
       try {
         descriptor = Object.getOwnPropertyDescriptor(obj, methodName);
       } catch(e) {