Fix Code Climate issues #27
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -87,10 +87,10 @@ | |||
|
|
|||
| it 'uses custom log file' do | |||
| Ngrok::Wrapper.start(log: 'test.log') | |||
| expect(Ngrok::Wrapper.running?).to eq true | |||
| expect(Ngrok::Wrapper.running?).to be_truthy | |||
There was a problem hiding this comment.
Prefer using be_running matcher over running?. (https://rspec.rubystyle.guide/#predicate-matchers, https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PredicateMatcher)
| expect(Ngrok::Wrapper.params[:log].path).to eq 'test.log' | ||
| Ngrok::Wrapper.stop | ||
| expect(Ngrok::Wrapper.stopped?).to eq true | ||
| expect(Ngrok::Wrapper.stopped?).to be_truthy |
There was a problem hiding this comment.
Prefer using be_stopped matcher over stopped?. (https://rspec.rubystyle.guide/#predicate-matchers, https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PredicateMatcher)
|
Code Climate has analyzed commit 42f070f and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.5% (0.0% change). View more on Code Climate. |
No description provided.