forked from pentaho/pentaho-kettle
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request pentaho#6953 from bmorrise/PDI-18360
[PDI-18360] Embed all needed run configurations in jobs
- Loading branch information
Showing
2 changed files
with
186 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139 changes: 139 additions & 0 deletions
139
...entaho/di/engine/configuration/impl/extension/RunConfigurationSaveExtensionPointTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| /* | ||
| * ***************************************************************************** | ||
| * | ||
| * Pentaho Data Integration | ||
| * | ||
| * Copyright (C) 2019 by Hitachi Vantara : http://www.pentaho.com | ||
| * | ||
| * ******************************************************************************* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use | ||
| * this file except in compliance with the License. You may obtain a copy of the | ||
| * License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * ***************************************************************************** | ||
| * | ||
| */ | ||
|
|
||
| package org.pentaho.di.engine.configuration.impl.extension; | ||
|
|
||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.mockito.Mock; | ||
| import org.mockito.runners.MockitoJUnitRunner; | ||
| import org.pentaho.di.core.attributes.metastore.EmbeddedMetaStore; | ||
| import org.pentaho.di.core.logging.LogChannelInterface; | ||
| import org.pentaho.di.engine.configuration.api.RunConfiguration; | ||
| import org.pentaho.di.engine.configuration.impl.RunConfigurationManager; | ||
| import org.pentaho.di.job.JobMeta; | ||
| import org.pentaho.di.job.entries.job.JobEntryJob; | ||
| import org.pentaho.di.job.entries.trans.JobEntryTrans; | ||
| import org.pentaho.di.job.entry.JobEntryCopy; | ||
| import org.pentaho.di.job.entry.JobEntryInterface; | ||
| import org.pentaho.di.job.entry.JobEntryRunConfigurableInterface; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| import static org.mockito.Matchers.anyString; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.times; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| @RunWith( MockitoJUnitRunner.class ) | ||
| public class RunConfigurationSaveExtensionPointTest { | ||
|
|
||
| private static final int JOB_ENTRY_COUNT = 10; | ||
| private static final String RUN_CONFIGURATION = "Run Configuration "; | ||
| public static final String RUN_CONFIG_VARIBLE = "${RUN_CONFIG_VARIBLE}"; | ||
|
|
||
| @Mock private JobMeta jobMeta; | ||
| @Mock private LogChannelInterface log; | ||
| @Mock private EmbeddedMetaStore embeddedMetaStore; | ||
| @Mock private RunConfigurationManager runConfigurationManager; | ||
|
|
||
| @Before | ||
| public void setup() { | ||
| when( jobMeta.getEmbeddedMetaStore() ).thenReturn( embeddedMetaStore ); | ||
| for ( int i = 0; i < JOB_ENTRY_COUNT; i++ ) { | ||
| String configurationName = RUN_CONFIGURATION + i; | ||
| RunConfiguration runConfiguration = mock( RunConfiguration.class ); | ||
| when( runConfiguration.getName() ).thenReturn( configurationName ); | ||
| when( runConfigurationManager.load( configurationName ) ).thenReturn( runConfiguration ); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testCallExtensionPointMultipleConfigs() throws Exception { | ||
| List<JobEntryCopy> jobEntryCopies = new ArrayList<>(); | ||
| for ( int i = 0; i < JOB_ENTRY_COUNT; i++ ) { | ||
| Class<? extends JobEntryRunConfigurableInterface> type = | ||
| i < JOB_ENTRY_COUNT / 2 ? JobEntryJob.class : JobEntryTrans.class; | ||
| String configurationName = RUN_CONFIGURATION + i; | ||
| jobEntryCopies.add( createCopy( type, configurationName ) ); | ||
| } | ||
| when( jobMeta.getJobCopies() ).thenReturn( jobEntryCopies ); | ||
|
|
||
| RunConfigurationSaveExtensionPoint runConfigurationSaveExtensionPoint = | ||
| new RunConfigurationSaveExtensionPoint( runConfigurationManager ); | ||
| runConfigurationSaveExtensionPoint.callExtensionPoint( log, new Object[] { jobMeta } ); | ||
|
|
||
| for ( int i = 0; i < JOB_ENTRY_COUNT; i++ ) { | ||
| String configurationName = RUN_CONFIGURATION + i; | ||
| verify( runConfigurationManager ).load( configurationName ); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testCallExtensionPointOneConfig() throws Exception { | ||
| List<JobEntryCopy> jobEntryCopies = new ArrayList<>(); | ||
| for ( int i = 0; i < JOB_ENTRY_COUNT; i++ ) { | ||
| Class<? extends JobEntryRunConfigurableInterface> type = | ||
| i < JOB_ENTRY_COUNT / 2 ? JobEntryJob.class : JobEntryTrans.class; | ||
| jobEntryCopies.add( createCopy( type, RUN_CONFIGURATION + "0" ) ); | ||
| } | ||
| when( jobMeta.getJobCopies() ).thenReturn( jobEntryCopies ); | ||
|
|
||
| RunConfigurationSaveExtensionPoint runConfigurationSaveExtensionPoint = | ||
| new RunConfigurationSaveExtensionPoint( runConfigurationManager ); | ||
| runConfigurationSaveExtensionPoint.callExtensionPoint( log, new Object[] { jobMeta } ); | ||
|
|
||
| verify( runConfigurationManager, times( 1 ) ).load( anyString() ); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCallExtensionPointAllConfigs() throws Exception { | ||
| List<JobEntryCopy> jobEntryCopies = new ArrayList<>(); | ||
| jobEntryCopies.add( createCopy( JobEntryJob.class, RUN_CONFIGURATION + "0" ) ); | ||
| jobEntryCopies.add( createCopy( JobEntryTrans.class, RUN_CONFIGURATION + "1" ) ); | ||
| jobEntryCopies.add( createCopy( JobEntryJob.class, RUN_CONFIGURATION + "2" ) ); | ||
| jobEntryCopies.add( createCopy( JobEntryTrans.class, RUN_CONFIG_VARIBLE ) ); | ||
| when( jobMeta.getJobCopies() ).thenReturn( jobEntryCopies ); | ||
|
|
||
| RunConfigurationSaveExtensionPoint runConfigurationSaveExtensionPoint = | ||
| new RunConfigurationSaveExtensionPoint( runConfigurationManager ); | ||
| runConfigurationSaveExtensionPoint.callExtensionPoint( log, new Object[] { jobMeta } ); | ||
|
|
||
| verify( runConfigurationManager ).load(); | ||
| } | ||
|
|
||
| private JobEntryCopy createCopy( Class<? extends JobEntryRunConfigurableInterface> type, | ||
| String runConfigurationName ) { | ||
| JobEntryCopy jobEntryCopy = mock( JobEntryCopy.class ); | ||
| JobEntryRunConfigurableInterface jobEntryInterface = mock( type ); | ||
|
|
||
| when( jobEntryCopy.getEntry() ).thenReturn( (JobEntryInterface) jobEntryInterface ); | ||
| when( jobEntryInterface.getRunConfiguration() ).thenReturn( runConfigurationName ); | ||
|
|
||
| return jobEntryCopy; | ||
| } | ||
| } |