Skip to content

Commit

Permalink
configure: Do not put arguments into double quotes
Browse files Browse the repository at this point in the history 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14777

This could create an issue that arguments don't get split by python and then the
following could happen:

    ./configure --libdir=/usr/lib64 --enable-clangdb

    LIBDIR='/usr/lib64 --enable-clangdb'

This ends then up in parameters.all.xml:

    <!ENTITY pathconfig.LIBDIR   '/usr/lib64 --enable-clangdb'>

The python parser then errors out:

    xml.etree.ElementTree.ParseError: not well-formed (invalid token)

Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>

Autobuild-User(master): Andreas Schneider <[email protected]>
Autobuild-Date(master): Tue Aug  3 18:36:37 UTC 2021 on sn-devel-184
  • Loading branch information
@cryptomilk
cryptomilk committed Aug 3, 2021
1 parent 93bac5f commit e2962b4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ export JOBS
unset LD_PRELOAD

cd . || exit 1
$PYTHON $WAF configure "$@" || exit 1
$PYTHON $WAF configure $@ || exit 1
cd $PREVPATH

0 comments on commit e2962b4

Please sign in to comment.