Block pausing of VMIs with LivenessProbe

Signed-off-by: Marc Sluiter <[email protected]>

pkg/virt-api/rest/subresource.go

@@ -622,6 +622,9 @@ func (app *SubresourceAPIApp) PauseVMIRequestHandler(request *restful.Request, r
 		if vmi == nil || vmi.Status.Phase != v1.Running {
 			return fmt.Errorf("VMI is not running"), http.StatusForbidden
 		}
+		if vmi.Spec.LivenessProbe != nil {
+			return fmt.Errorf("Pausing VMIs with LivenessProbe is currently not supported"), http.StatusForbidden
+		}
 		condManager := controller.NewVirtualMachineInstanceConditionManager()
 		if condManager.HasCondition(vmi, v1.VirtualMachineInstancePaused) {
 			return fmt.Errorf("VMI is already paused"), http.StatusForbidden

tests/pausing_test.go

@@ -24,6 +24,8 @@ import (
 	"strings"
 	"time"
 
+	"k8s.io/apimachinery/pkg/util/intstr"
+
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 
@@ -90,6 +92,35 @@ var _ = Describe("[rfe_id:3064][crit:medium][vendor:[email protected]][level:com
 				tests.WaitForVMIConditionRemovedOrFalse(virtClient, vmi, v1.VirtualMachineInstancePaused, 30)
 			})
 		})
+
+		Context("with a LivenessProbe configured", func() {
+			When("paused via virtctl", func() {
+				It("should not be paused", func() {
+					By("Launching a VMI with LivenessProbe")
+					vmi = tests.NewRandomVMIWithEphemeralDisk(tests.ContainerDiskFor(tests.ContainerDiskCirros))
+					// a random probe wich will not fail immediately
+					vmi.Spec.LivenessProbe = &v1.Probe{
+						Handler: v1.Handler{
+							HTTPGet: &k8sv1.HTTPGetAction{
+								Path: "/something",
+								Port: intstr.FromInt(8080),
+							},
+						},
+						InitialDelaySeconds: 120,
+						TimeoutSeconds:      120,
+						PeriodSeconds:       120,
+						SuccessThreshold:    1,
+						FailureThreshold:    1,
+					}
+					tests.RunVMIAndExpectLaunch(vmi, 90)
+
+					By("Pausing it")
+					command := tests.NewRepeatableVirtctlCommand("pause", "vmi", "--namespace", tests.NamespaceTestDefault, vmi.Name)
+					err := command()
+					Expect(err.Error()).To(ContainSubstring("Pausing VMIs with LivenessProbe is currently not supported"))
+				})
+			})
+		})
 	})
 
 	Context("A valid VM", func() {