Skip to content

Commit

Permalink
Remove dependancy on j2cli python package
Browse files Browse the repository at this point in the history
Requiring installation of the python jinja CLI tool with pip
is overkill for subsituting a couple of plain strings into
a text file.

Signed-off-by: Daniel P. Berrange <[email protected]>
  • Loading branch information
berrange committed May 30, 2017
1 parent 5fd6b93 commit 6edd8af
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 0 additions & 4 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ to install a few build requirements:
# We are interfacing with libvirt
sudo dnf install libvirt-devel

sudo dnf install python-pip
sudo pip install j2cli


cd $GOPATH
# Use goimports for package import ordering
go get golang.org/x/tools/cmd/goimports
Expand Down
5 changes: 4 additions & 1 deletion hack/build-manifests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,8 @@ rm -f "manifests/*.yaml"

# Render kubernetes manifests
for arg in $args; do
env | j2 --format=env $arg > ${arg%%.in}
sed -e "s/{{ master_ip }}/$master_ip/g" \
-e "s/{{ docker_tag }}/$docker_tag/g" \
-e "s/{{ docker_prefix }}/$docker_prefix/g" \
$arg > ${arg%%.in}
done

0 comments on commit 6edd8af

Please sign in to comment.