Add goimports support to bazel

BUILD.bazel

@@ -1,6 +1,15 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("@bazel_gazelle//:def.bzl", "gazelle")
 load("@io_bazel_rules_go//go:def.bzl", "nogo")
+load("@com_github_atlassian_bazel_tools//goimports:def.bzl", "goimports")
+
+goimports(
+    name = "goimports",
+    display_diffs = True,
+    local = ["kubevirt.io"],
+    prefix = "kubevirt.io/kubevirt",
+    write = True,
+)
 
 nogo(
     name = "nogo_vet",

WORKSPACE

@@ -7,8 +7,8 @@ load(
 # Additional bazel rules
 http_archive(
     name = "io_bazel_rules_go",
-    urls = ["https://github.com/bazelbuild/rules_go/releases/download/0.18.0/rules_go-0.18.0.tar.gz"],
     sha256 = "301c8b39b0808c49f98895faa6aa8c92cbd605ab5ad4b6a3a652da33a1a2ba2e",
+    urls = ["https://github.com/bazelbuild/rules_go/releases/download/0.18.0/rules_go-0.18.0.tar.gz"],
 )
 
 http_archive(
@@ -35,6 +35,12 @@ git_repository(
     tag = "v0.5.1",
 )
 
+http_archive(
+    name = "com_github_atlassian_bazel_tools",
+    strip_prefix = "bazel-tools-02472d814d1867de2ad75801760732c9e595c9d9",
+    urls = ["https://github.com/atlassian/bazel-tools/archive/02472d814d1867de2ad75801760732c9e595c9d9.zip"],
+)
+
 # Libvirt dependencies
 http_file(
     name = "libvirt_libs",
@@ -96,7 +102,11 @@ go_rules_dependencies()
 go_register_toolchains(
     go_version = "1.11.5",
     nogo = "@//:nogo_vet",
-        )
+)
+
+load("@com_github_atlassian_bazel_tools//goimports:deps.bzl", "goimports_dependencies")
+
+goimports_dependencies()
 
 load(
     "@bazel_gazelle//:deps.bzl",

cmd/virt-operator/virt-operator.go

@@ -23,7 +23,7 @@ import (
 	_ "kubevirt.io/kubevirt/pkg/monitoring/client/prometheus"    // import for prometheus metrics
 	_ "kubevirt.io/kubevirt/pkg/monitoring/reflector/prometheus" // import for prometheus metrics
 	_ "kubevirt.io/kubevirt/pkg/monitoring/workqueue/prometheus" // import for prometheus metrics
-	"kubevirt.io/kubevirt/pkg/virt-operator"
+	virt_operator "kubevirt.io/kubevirt/pkg/virt-operator"
 )
 
 func main() {

nogo_config.json

@@ -1,102 +1,122 @@
 {
   "structtag": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "asmdecl": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "assign": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "atomic": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "bools": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "buildtag": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "cgocall": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "composites": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "copylocks": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "httpresponse": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "loopclosure": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "lostcancel": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "nilfunc": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "printf": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "shift": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "stdmethods": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "tests": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "unreachable": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "unsafeptr": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   },
   "unusedresult": {
     "exclude_files": {
-      "vendor/": "vendor doesn't pass vet"
+      "vendor/": "vendor doesn't pass vet",
+      "external/": "externaldoesn't pass vet"
     }
   }
 }

pkg/api/v1/types.go

@@ -32,7 +32,7 @@ import (
 	"encoding/json"
 	"fmt"
 
-	"k8s.io/api/autoscaling/v1"
+	v1 "k8s.io/api/autoscaling/v1"
 	k8sv1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/ignition/ignition.go

@@ -25,7 +25,7 @@ import (
 	"io/ioutil"
 	"os"
 
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 	diskutils "kubevirt.io/kubevirt/pkg/ephemeral-disk-utils"
 	"kubevirt.io/kubevirt/pkg/log"
 	"kubevirt.io/kubevirt/pkg/precond"

pkg/kubecli/kubevirt.go

@@ -41,7 +41,7 @@ import (
 	networkclient "github.com/k8snetworkplumbingwg/network-attachment-definition-client/pkg/client/clientset/versioned"
 
 	cdiclient "kubevirt.io/containerized-data-importer/pkg/client/clientset/versioned"
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 )
 
 type KubevirtClient interface {

pkg/kubecli/kv.go

@@ -25,7 +25,7 @@ import (
 	"k8s.io/client-go/kubernetes/scheme"
 	"k8s.io/client-go/rest"
 
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 )
 
 func (k *kubevirt) KubeVirt(namespace string) KubeVirtInterface {

pkg/kubecli/replicaset.go

@@ -26,7 +26,7 @@ import (
 	"k8s.io/client-go/kubernetes/scheme"
 	"k8s.io/client-go/rest"
 
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 )
 
 func (k *kubevirt) ReplicaSet(namespace string) ReplicaSetInterface {

pkg/kubecli/replicaset_test.go

@@ -25,7 +25,7 @@ import (
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 	"github.com/onsi/gomega/ghttp"
-	"k8s.io/api/autoscaling/v1"
+	v1 "k8s.io/api/autoscaling/v1"
 	k8sv1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	k8smetav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/util/openapi/openapi.go

@@ -5,7 +5,7 @@ import (
 	"strings"
 
 	"github.com/emicklei/go-restful"
-	"github.com/emicklei/go-restful-openapi"
+	restfulspec "github.com/emicklei/go-restful-openapi"
 	"github.com/go-openapi/errors"
 	"github.com/go-openapi/spec"
 	"github.com/go-openapi/strfmt"

pkg/virt-controller/services/template.go

@@ -43,7 +43,7 @@ import (
 	"kubevirt.io/kubevirt/pkg/util/hardware"
 	"kubevirt.io/kubevirt/pkg/util/net/dns"
 	"kubevirt.io/kubevirt/pkg/util/types"
-	"kubevirt.io/kubevirt/pkg/virt-config"
+	virtconfig "kubevirt.io/kubevirt/pkg/virt-config"
 )
 
 const configMapName = "kubevirt-config"

pkg/virt-controller/services/template_test.go

@@ -41,7 +41,7 @@ import (
 	"kubevirt.io/kubevirt/pkg/hooks"
 	"kubevirt.io/kubevirt/pkg/kubecli"
 	"kubevirt.io/kubevirt/pkg/log"
-	"kubevirt.io/kubevirt/pkg/virt-config"
+	virtconfig "kubevirt.io/kubevirt/pkg/virt-config"
 )
 
 const namespaceKubevirt = "kubevirt"

pkg/virt-controller/watch/replicaset_test.go

@@ -10,10 +10,10 @@ import (
 	k8sv1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/tools/cache"
-	"k8s.io/client-go/tools/cache/testing"
+	framework "k8s.io/client-go/tools/cache/testing"
 	"k8s.io/client-go/tools/record"
 
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 	"kubevirt.io/kubevirt/pkg/kubecli"
 	"kubevirt.io/kubevirt/pkg/testutils"
 )

pkg/virt-controller/watch/vm_test.go

@@ -15,12 +15,12 @@ import (
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/testing"
 	"k8s.io/client-go/tools/cache"
-	"k8s.io/client-go/tools/cache/testing"
+	framework "k8s.io/client-go/tools/cache/testing"
 	"k8s.io/client-go/tools/record"
 
 	cdiv1 "kubevirt.io/containerized-data-importer/pkg/apis/core/v1alpha1"
 	cdifake "kubevirt.io/containerized-data-importer/pkg/client/clientset/versioned/fake"
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 	virtv1 "kubevirt.io/kubevirt/pkg/api/v1"
 	"kubevirt.io/kubevirt/pkg/kubecli"
 	"kubevirt.io/kubevirt/pkg/testutils"

pkg/virt-controller/watch/vmi.go

@@ -26,7 +26,7 @@ import (
 	"time"
 
 	k8sv1 "k8s.io/api/core/v1"
-	"k8s.io/apimachinery/pkg/apis/meta/v1"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/apimachinery/pkg/util/wait"
 	"k8s.io/client-go/tools/cache"

pkg/virt-operator/application.go

@@ -41,7 +41,7 @@ import (
 	"kubevirt.io/kubevirt/pkg/log"
 	"kubevirt.io/kubevirt/pkg/service"
 	kvutil "kubevirt.io/kubevirt/pkg/util"
-	"kubevirt.io/kubevirt/pkg/virt-operator/install-strategy"
+	installstrategy "kubevirt.io/kubevirt/pkg/virt-operator/install-strategy"
 	"kubevirt.io/kubevirt/pkg/virt-operator/util"
 )
 

pkg/virt-operator/install-strategy/strategy.go

@@ -37,7 +37,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 	"kubevirt.io/kubevirt/pkg/controller"
 	"kubevirt.io/kubevirt/pkg/kubecli"
 	"kubevirt.io/kubevirt/pkg/log"

pkg/virt-operator/kubevirt.go

@@ -34,11 +34,11 @@ import (
 	"k8s.io/client-go/tools/record"
 	"k8s.io/client-go/util/workqueue"
 
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 	"kubevirt.io/kubevirt/pkg/controller"
 	"kubevirt.io/kubevirt/pkg/kubecli"
 	"kubevirt.io/kubevirt/pkg/log"
-	"kubevirt.io/kubevirt/pkg/virt-operator/install-strategy"
+	installstrategy "kubevirt.io/kubevirt/pkg/virt-operator/install-strategy"
 	"kubevirt.io/kubevirt/pkg/virt-operator/util"
 )
 

pkg/virt-operator/kubevirt_test.go

@@ -43,17 +43,17 @@ import (
 	"k8s.io/client-go/kubernetes/fake"
 	"k8s.io/client-go/testing"
 	"k8s.io/client-go/tools/cache"
-	"k8s.io/client-go/tools/cache/testing"
+	framework "k8s.io/client-go/tools/cache/testing"
 	"k8s.io/client-go/tools/record"
 
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 	"kubevirt.io/kubevirt/pkg/kubecli"
 	"kubevirt.io/kubevirt/pkg/log"
 	"kubevirt.io/kubevirt/pkg/testutils"
 	"kubevirt.io/kubevirt/pkg/version"
 	"kubevirt.io/kubevirt/pkg/virt-operator/creation/components"
 	"kubevirt.io/kubevirt/pkg/virt-operator/creation/rbac"
-	"kubevirt.io/kubevirt/pkg/virt-operator/install-strategy"
+	installstrategy "kubevirt.io/kubevirt/pkg/virt-operator/install-strategy"
 	"kubevirt.io/kubevirt/pkg/virt-operator/util"
 )
 

pkg/virt-operator/util/client_test.go

@@ -33,7 +33,7 @@ import (
 	discoveryFake "k8s.io/client-go/discovery/fake"
 	"k8s.io/client-go/kubernetes/fake"
 
-	"kubevirt.io/kubevirt/pkg/api/v1"
+	v1 "kubevirt.io/kubevirt/pkg/api/v1"
 	"kubevirt.io/kubevirt/pkg/kubecli"
 )
 

pkg/virtctl/imageupload/imageupload_test.go

@@ -13,7 +13,7 @@ import (
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/ginkgo/extensions/table"
 	. "github.com/onsi/gomega"
-	"k8s.io/api/core/v1"
+	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"