Revise the condition of ReleaseMatricesAfterForwardProp: only ValueSh…

…arable nodes can be released after forwardprop
thanaphatp · Jan 12, 2016 · 0b8e30e · 0b8e30e
1 parent 4b1f800
commit 0b8e30e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Source/ComputationNetworkLib/ComputationNode.h b/Source/ComputationNetworkLib/ComputationNode.h
@@ -545,7 +545,7 @@ namespace Microsoft { namespace MSR { namespace CNTK {
         void SetOutputNeededDuringBackprop(bool f) { m_outputNeededDuringBackprop = f; }
         bool IsOutputNeededDuringBackprop() const 
         {
-            return !g_shareNodeValueMatrices || m_outputNeededDuringBackprop || !isValueSharable();
+            return !g_shareNodeValueMatrices || m_outputNeededDuringBackprop ;
         }
 
         const size_t GetNumInputs() const { return m_inputs.size(); }
@@ -912,7 +912,7 @@ namespace Microsoft { namespace MSR { namespace CNTK {
         //don't release matrices that need to be used in the gradient computation
         virtual void ReleaseMatricesAfterForwardProp(MatrixPool& matrixPool)
         {
-            if (!IsOutputNeededDuringBackprop() && (m_value->GetMatrixType() != SPARSE))
+            if (!IsOutputNeededDuringBackprop() && (m_value->GetMatrixType() != SPARSE) && isValueSharable())
                 ReleaseMatrixToPool(m_value, matrixPool);
         }