forked from MouseLand/suite2p
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suite2p wang lab1 #3
Open
Zhuoyang-Ye
wants to merge
19
commits into
the-wang-lab:main
Choose a base branch
from
the-wang-lab:suite2p-wang-lab1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thresholds are determined based on the mean and std of the image stack. Four thresholds are introduced: 1. thresh_peak_norm: the threshold calculated using mean+3*sd of mov_norm. It is used to identify active frames for each newly added ROI. 2. thresh_act_pix: the threshold is also calculated using mean+scaling*sd of mov_norm. It should be lower than thresh_peak_norm, and used to determine how much an ROI can expand. This parameter shares the same name as the original parameter used for a similar purpose but without threshold determination based on the imaging stack. 3. thresh_peak: the threshold calculated based on the down-sampled movie at the selected spatial scale. It is calculated using mean+3*sd of mov_norm_down[spatial_scale]. It is used to threshold the mov_norm_down and then calculating their sd to get mov_norm_sd_down. 4. thresh_peak_sd_down: the threshold calculated using mean + scaling*sd of mov_norm_sd_down[spatial_scale]. It is used to peak the next ROI location in mov_norm_sd_down[spatial_scale] that is larger than this threshold.
…ilter and normalization This is to ensure that the mov_norm has a zero mean for each pixel. Also, it seems that normalizing with the max value is easier to visualize the hotspots than normalizing with sd.
1. Added median filter in addition to max and mean filter 2. Since mov_norm has 0 mean, for pixels with high std, they typically have both high positive and negative values. When calculating lam values in iter_extend and selecting active frames, should consider both the positive and negative changes
This detect function is in the file detect.py. Adding the option to use "wang:bin_size" to control binning frames before processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.