Add customizable column to React HostsIndex page #399
Merged
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris1984
approved these changes
May 28, 2024
|
@stejskalleos how does this look? |
@stejskalleos I got a new dev setup working after all, so I could do the review! |
jeremylenz
force-pushed
the
foreman-puppet-hosts-columns
branch
from
7439a01 to
d38d6e5
Compare
|
Thanks @nadjaheitmann, updated! (with one reply above) |
jeremylenz
force-pushed
the
foreman-puppet-hosts-columns
branch
from
d38d6e5 to
3abb543
Compare
|
fixed lint |
nadjaheitmann
approved these changes
May 29, 2024
|
Which is the minimum Foreman version that supports this fix? |
|
I believe it should be 3.11: https://projects.theforeman.org/issues/37293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "Puppet env" column to the new React All Hosts page.
For a demo with some more context, see https://www.youtube.com/watch?v=bzZEOiJOrCg&t=1808s
This will bring "column parity" for foreman_puppet between the legacy and new All Hosts page.