Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36207 - Setup puppet during Host Registration #402

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fixes #36207 - Setup puppet during Host Registration #402

merged 1 commit into from
Jul 12, 2024
+22 −0

Conversation

sbernhard
Copy link
Contributor

No description provided.

@sbernhard sbernhard force-pushed the setup_puppet_during_hostreg branch 2 times, most recently from 80991eb to 4de1661 Compare July 4, 2024 12:01
@sbernhard sbernhard changed the title Setup puppet during Host Registration Fixes #36207 - Setup puppet during Host Registration Jul 4, 2024
@sbernhard sbernhard marked this pull request as ready for review July 4, 2024 12:01
@sbernhard sbernhard force-pushed the setup_puppet_during_hostreg branch from 4de1661 to 7002e58 Compare July 9, 2024 14:08
@sbernhard
Copy link
Contributor Author

@nadjaheitmann can you please have a look at this PR?

nadjaheitmann
nadjaheitmann approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@nadjaheitmann nadjaheitmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and puppet_proxy_id, puppet_ca_proxy_id and environment are set correctly.

@nadjaheitmann nadjaheitmann merged commit 23b7d8a into theforeman:master Jul 12, 2024
22 of 23 checks passed
@nadjaheitmann nadjaheitmann deleted the setup_puppet_during_hostreg branch July 12, 2024 07:07
@nadjaheitmann
Copy link
Collaborator

Thanks @sbernhard !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadjaheitmann nadjaheitmann nadjaheitmann approved these changes

Assignees
No one assigned
Labels
Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernhard @nadjaheitmann