Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37851 - Support Rails 7.0 #410

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ofedoren
Copy link
Member

No description provided.

@ofedoren ofedoren force-pushed the feat-37851-support-rails-7 branch from 1fa259b to 1e1a657 Compare October 17, 2024 10:36
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look like they're 6.1 compatible and I'd like to merge them.

@ofedoren ofedoren force-pushed the feat-37851-support-rails-7 branch from 1e1a657 to a4ec266 Compare October 22, 2024 15:09
@ofedoren
Copy link
Member Author

Dropped the last commit.

@ekohl ekohl merged commit 6f8266d into theforeman:master Oct 22, 2024
22 checks passed
@nadjaheitmann
Copy link
Collaborator

I read through the community post and I am not sure that I understand until when we need Rails 7 support. Can you clarify, please?

@ekohl
Copy link
Member

ekohl commented Oct 23, 2024

@nadjaheitmann this addresses some deprecations that already makes it compatible with Rails 7 while we can also ship with Rails 6.1, meaning we don't have to coordinate releases as much.

You should read https://community.theforeman.org/t/rails-7-upgrade/37771 though. We split off the effort, but the important thing to note is that Rails 6.1 is already out of security support. It's urgent that we upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants