Fixes #37979 - Fix puppet classes import filter when using Ruby 3+ and Regexp/Symbol in YAML file

[neomilium]

See details here: https://projects.theforeman.org/issues/37979

[nadjaheitmann]

Is this compatible with older Ruby versions?

[neomilium]

Is this compatible with older Ruby versions?

I just amended my commit, this should now be compatible with older Ruby versions.

[neomilium]

@nadjaheitmann Is there is anything I could do to help here?

[stejskalleos]

@neomilium hi, can you fix the rubocop findings and rebase the branch over the master? This should give us green CI

[neomilium]

@stejskalleos Done. Thanks.

[ekohl]

A difference is that they changed the load_file method to really be the safe_load_file method. Sadly on Psych bundled in Ruby 2.7, safe_load_file doesn't exist.

A way to avoid a specific version check is:

if File.exist?(ignored_file_path)
  # Ruby 3+
  if YAML.respond_to(:safe_load_file)
    YAML.safe_load_file(ignored_file_path, permitted_classes: [Symbol, Regexp])
  else
    YAML.load_file(ignored_file_path)
  end
else
  {}
end

Once we drop Ruby 2.7 support, you can drop the load_file call.

[neomilium]

@ekohl Your suggestion is now applied. Thanks.

[ekohl]

I'll admit I haven't tested this myself, but I'm approving CI to run.