fixes a bug where flycheck was not showing some warnings for .tsx #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed here: #156
It turns out that the checker chains are configurations that can be set only once, and they'll affect all invocations of flycheck, so instead of doing this in a web-mode hook, we can just do it once when setting up frontside-javascript.
cowboyd
approved these changes
Mar 10, 2022
|
Writing a test for this proved to be exceedingly difficult because it requires a full yarn install to work, so I just went ahead and merged. Also I found that we don't have to do this in a hook, we can do it once when we initially setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full bug discussion here:
#156
Motivation
When developing inside .tsx files, we had missing warnings from flycheck due from some disabling, it looked like we could only (manually) have ts-tide or javascript eslint, not both enabled.
Approach
Inside
frontside-javascript--tsx-web-mode-hookfunction we now disable all checkers and then add both'tsx-tide 'javascript-eslint.Alternate Designs
I am not sure how to do it another way, but this line might be optional:
(setq flycheck-disabled-checkers nil)