check for existance of window before assigning Facetr

thegass · Apr 26, 2013 · 02e8ffd · 02e8ffd
1 parent b024a4e
commit 02e8ffd
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/dist/backbone.facetr.js b/dist/backbone.facetr.js
@@ -1132,5 +1132,9 @@
     	collection.on('change', _modifyModel);
     };
 
-    return window.Facetr = Backbone.Facetr;
+    if(window){
+        window.Facetr = Backbone.Facetr;
+    }
+
+    return Backbone.Facetr;
 }));
diff --git a/dist/backbone.facetr.min.js b/dist/backbone.facetr.min.js
diff --git a/example/todos.html b/example/todos.html
@@ -188,7 +188,7 @@ <h4><%= facet.data.label %></h4>
 								// this.collection.on('reset', this.addAll, this);
 
 								this.collection.on('reset', this.addAll, this);
-								Facetr(this.collection).on('reset change remove add sort', this.addAll, this);
+								Facetr(this.collection).on('reset clear change remove add sort', this.addAll, this);
 
 								this.collection.reset(items);
 

diff --git a/spec/FacetrSpec.js b/spec/FacetrSpec.js
@@ -157,7 +157,7 @@ describe('Backbone.Facetr', function() {
 						// Facetr(collection).facet('UnexistingProperty');
 					// }).toThrow(new Error('Facetr cannot add a facet using a non-existent model property'));
 				});
-				
+
 				// Facet
 				describe('returns a Facet that', function() {
 					// Facet toJSON