openvidu-browser: typed OpenViduAdvancedConfiguration#publisherSpeaki…

…ngEventsOptions
theiosdevguy · May 27, 2021 · d320da6 · d320da6
1 parent 7895ac0
commit d320da6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/openvidu-browser/src/OpenVidu/StreamManager.ts b/openvidu-browser/src/OpenVidu/StreamManager.ts
@@ -392,7 +392,7 @@ export class StreamManager extends EventDispatcher {
      * - `interval`: (number) how frequently the analyser polls the audio stream to check if speaking has started/stopped or audio volume has changed. Default **100** (ms)
      * - `threshold`: (number) the volume at which _publisherStartSpeaking_, _publisherStopSpeaking_ events will be fired. Default **-50** (dB)
      */
-    updatePublisherSpeakingEventsOptions(publisherSpeakingEventsOptions): void {
+    updatePublisherSpeakingEventsOptions(publisherSpeakingEventsOptions: { interval?: number, threshold?: number }): void {
         const currentHarkOptions = !!this.stream.harkOptions ? this.stream.harkOptions : (this.stream.session.openvidu.advancedConfiguration.publisherSpeakingEventsOptions || {});
         const newInterval = (typeof publisherSpeakingEventsOptions.interval === 'number') ?
             publisherSpeakingEventsOptions.interval : ((typeof currentHarkOptions.interval === 'number') ? currentHarkOptions.interval : 100);

diff --git a/openvidu-browser/src/OpenViduInternal/Interfaces/Public/OpenViduAdvancedConfiguration.ts b/openvidu-browser/src/OpenViduInternal/Interfaces/Public/OpenViduAdvancedConfiguration.ts
@@ -39,7 +39,10 @@ export interface OpenViduAdvancedConfiguration {
      * 
      * This sets the global default configuration that will affect all streams, but you can later customize these values for each specific stream by calling [[StreamManager.updatePublisherSpeakingEventsOptions]]
      */
-    publisherSpeakingEventsOptions?: any;
+    publisherSpeakingEventsOptions?: {
+        interval?: number;
+        threshold?: number;
+    };
 
     /**
      * Determines the automatic reconnection process policy. Whenever the client's network drops, OpenVidu Browser starts a reconnection process with OpenVidu Server. After network is recovered, OpenVidu Browser automatically