-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ngrid #268
base: master
Are you sure you want to change the base?
Refactor ngrid #268
Conversation
Added support for non vectorized functions (slower) Added chunk size parameter for controlling memory/accuracy balance
Thanks @marco-2023 . I'm going to add @FarnazH to the review panel for this one. I'm also curious if @Ali-Tehrani has any comments/thoughts. |
I talked to @marco-2023 about this today. The main issue is that the I looked a little bit at the code. Some comments:
What do you think @Ali-Tehrani and @FarnazH ? |
Refactored the ngrid module to improve readability and add features.
@PaulWAyers I think this PR improved the previous class. Nonetheless, I still have some doubts:
Grid
because of this, several methods are inheritedmoments
,save
andget_localgrid
. I think thatsave
andget_localgrid
can be implemented (I have some doubts about the meaning ofget_localgrid
in this context ), but I don't see how to getmoments
.MultiDomainGridIntegrator
that is only responsible for integrating functions with more than one argument?