[Chore] Remove unused 'faucet' service from chain logic (thirdweb-dev…

…#4038)
theonrex · Aug 11, 2024 · c316174 · c316174
1 parent 40fbe9a
commit c316174
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/apps/dashboard/src/app/(dashboard)/(chain)/chainlist/page.tsx b/apps/dashboard/src/app/(dashboard)/(chain)/chainlist/page.tsx
@@ -96,12 +96,6 @@ async function getChainsToRender(params: SearchParams) {
       // if the chain does not have all of the services in the filter, return false to filter it out
       if (
         !urlServiceArray.every((service) => {
-          // TODO improve this
-          // We don't have "faucet" added in services array, so for now we just check if it's testnet or not
-          if (service === "faucet") {
-            return chain.testnet;
-          }
-
           return chain.services.find((s) => s.enabled && s.service === service);
         })
       ) {

diff --git a/apps/dashboard/src/app/(dashboard)/(chain)/types/chain.ts b/apps/dashboard/src/app/(dashboard)/(chain)/types/chain.ts
@@ -6,7 +6,6 @@ export type ChainSupportedService =
   | "engine"
   | "account-abstraction"
   | "pay"
-  | "faucet"
   | "rpc-edge"
   | "chainsaw";
 

diff --git a/apps/dashboard/src/components/buttons/MismatchButton.tsx b/apps/dashboard/src/components/buttons/MismatchButton.tsx
@@ -277,9 +277,7 @@ function NoFundsDialogContent(props: {
             {props.chain.id === localhost.id ? (
               // localhost case
               <GetLocalHostTestnetFunds />
-            ) : chainWithServiceInfoQuery.data.services.find(
-                (x) => x.enabled && x.service === "faucet",
-              ) ? (
+            ) : chainWithServiceInfoQuery.data.testnet ? (
               // faucet case
               <GetFundsFromFaucet chain={chainWithServiceInfoQuery.data} />
             ) : chainWithServiceInfoQuery.data.services.find(