Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Implicitly enable Jira integration via API key #9

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

constantincerdan
Copy link
Collaborator

Removes the need to explicitly enable Jira integration via the JIRA_INTEGRATION_ENABLED env variable by implicitly enabling it if the JIRA_API_KEY env variable is provided.

@anno-bot
Copy link

anno-bot bot commented Dec 26, 2024

This PR may contain the following bugs:
  1. Model Name Error:
export CHAT_GPT_MODEL=gpt-4o-2024-08-06

The model name contains a typo - it uses 'o' instead of '0'. The correct format should be 'gpt-40-2024-08-06'.

  1. Future Date in Model Names:
export CHAT_GPT_MODEL=gpt-4o-2024-08-06
export CLAUDE_MODEL=claude-3-5-sonnet-20241022

Both model names contain future dates (2024) which don't exist yet, making these model identifiers invalid for current use.

  1. Potential Missing Validation:
let jira_enabled = config::get_optional("JIRA_API_KEY").is_some();

The code only checks if the JIRA_API_KEY exists but doesn't validate if other required Jira configurations (JIRA_BASE_URL, JIRA_PROJECT_KEY) are present when Jira is enabled, which could lead to runtime errors.

@constantincerdan constantincerdan merged commit 35cba5b into master Dec 26, 2024
1 check passed
@constantincerdan constantincerdan deleted the feature/implicit-jira-integration branch December 26, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant