ensure role name properly encoded (#783)

Signed-off-by: Brian DeHamer <[email protected]>

.changeset/quick-boxes-move.md

@@ -0,0 +1,5 @@
+---
+'tuf-js': patch
+---
+
+Ensure that role names are properly encoded when used in URLs or file names

packages/client/src/updater.ts

@@ -331,9 +331,10 @@ export class Updater {
         ? metaInfo.version
         : undefined;
 
+      const encodedRole = encodeURIComponent(role);
       const metadataUrl = url.join(
         this.metadataBaseUrl,
-        version ? `${version}.${role}.json` : `${role}.json`
+        version ? `${version}.${encodedRole}.json` : `${encodedRole}.json`
       );
 
       try {
@@ -439,13 +440,14 @@ export class Updater {
   }
 
   private persistMetadata(metaDataName: string, bytesData: Buffer) {
+    const encodedName = encodeURIComponent(metaDataName);
     try {
-      const filePath = path.join(this.dir, `${metaDataName}.json`);
+      const filePath = path.join(this.dir, `${encodedName}.json`);
       log('WRITE %s', filePath);
       fs.writeFileSync(filePath, bytesData.toString('utf8'));
     } catch (error) {
       throw new PersistError(
-        `Failed to persist metadata ${metaDataName} error: ${error}`
+        `Failed to persist metadata ${encodedName} error: ${error}`
       );
     }
   }