[Dashboard] Feature: UI for crosschain modules #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GWSzeto
requested review from
jnsdls,
MananTank and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5399 +/- ##
=======================================
Coverage 56.85% 56.86%
=======================================
Files 1166 1166
Lines 64526 64576 +50
Branches 5223 5238 +15
=======================================
+ Hits 36686 36720 +34
- Misses 27115 27130 +15
- Partials 725 726 +1
*This pull request uses carry forward flags. Click here to find out more.
|
size-limit report 📦
|
|
@GWSzeto could you reference a linear ticket in the description |
gregfromstl
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/cross-chain/page.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/cross-chain/page.tsx
Outdated
Show resolved
Hide resolved
kumaryash90
added
merge-queue
kumaryash90
approved these changes
Feb 14, 2025
MananTank
approved these changes
Feb 14, 2025
gregfromstl
approved these changes
Feb 14, 2025
joaquim-verges
approved these changes
Feb 14, 2025
https://linear.app/thirdweb/project/[modular-contracts]-op-interoperability-module-87740e1390a9/overview <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces new features and improvements related to cross-chain contract deployment in the `thirdweb` framework, enhancing functionality and usability for developers. ### Detailed summary - Added `getDeployedCloneFactoryContract` export in `contract.ts`. - Introduced `moduleInstalledEvent` export in `modules.ts`. - Updated TypeScript documentation links. - Enhanced sidebar links in `getContractPageSidebarLinks.ts`. - Improved `namehash.ts` with typed return value. - Created `NoCrossChainPrompt` component for user feedback. - Added `nonce` and `initializeData` options in `installPublishedModule.ts`. - Updated event handling for `ProxyDeployedV2`. - Implemented cross-chain deployment logic in various files. - Updated tests to cover new cross-chain functionality. - Refactored contract deployment methods to support new parameters. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
crosschain-ui
branch
from
f7030d3 to
557d3e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/project/[modular-contracts]-op-interoperability-module-87740e1390a9/overview
PR-Codex overview
This PR introduces new functionalities and improvements related to cross-chain deployments, event handling, and contract deployment mechanisms in the
thirdwebpackage.Detailed summary
getDeployedCloneFactoryContractexport.moduleInstalledEventexport._utils/getContractPageSidebarLinks.tswith a new "Cross Chain (Beta)" link.keccak256result handling innamehash.ts.NoCrossChainPromptcomponent for user notifications.nonceininstallPublishedModule.deploy-via-autofactory.ts.ProxyDeployedV2.deployContractfromDeployMetadatato support cross-chain options.DataTableto manage cross-chain deployment status.