[SDK] Add onClose callback to details modal #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e9c23ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
joaquim-verges,
gregfromstl,
MananTank,
jnsdls and
edwardysun
as code owners
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5605 +/- ##
==========================================
+ Coverage 54.12% 54.53% +0.40%
==========================================
Files 1102 1105 +3
Lines 59206 59332 +126
Branches 4886 4924 +38
==========================================
+ Hits 32044 32354 +310
+ Misses 26438 26258 -180
+ Partials 724 720 -4
*This pull request uses carry forward flags. Click here to find out more.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
kien-ngo
force-pushed
the
kien/onClose-callback-modal
branch
from
4e1ad8d to
a1ddcc2
Compare
kien-ngo
force-pushed
the
kien/onClose-callback-modal
branch
from
a1ddcc2 to
d15a998
Compare
gregfromstl
approved these changes
Dec 4, 2024
kien-ngo
force-pushed
the
kien/onClose-callback-modal
branch
from
f7728bd to
ee38970
Compare
kien-ngo
force-pushed
the
kien/onClose-callback-modal
branch
from
ee38970 to
c6ef3f2
Compare
kien-ngo
force-pushed
the
kien/onClose-callback-modal
branch
from
c6ef3f2 to
1154410
Compare
gregfromstl
approved these changes
Dec 25, 2024
CNCT-2444 CNCT-2444 <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily introduces an `onClose` callback for the `ConnectButton` component's details modal, enhancing its functionality. It also improves the rendering of various components and adds tests for new features. ### Detailed summary - Added `onClose` callback to `ConnectButtonProps` for modal closure. - Updated `ConnectButton` to utilize the `onClose` callback. - Improved test coverage for `NetworkSwitcherButton` and `ChainIcon`. - Enhanced `fetchChainIcon` functionality to handle various icon resolvers. - Introduced `ChainActiveDot` for visual representation of active chains. - Updated `NetworkSelector` and `DetailsModal` components for better user experience. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/onClose-callback-modal
branch
from
1154410 to
e9c23ad
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2444
CNCT-2444
PR-Codex overview
This PR focuses on enhancing the
ConnectButtoncomponent by adding anonClosecallback for the details modal, improving functionality and user experience. It also includes various updates to theChainIcon,NetworkSwitcherButton, and related components.Detailed summary
onClosecallback toConnectButtonPropsfor modal closure.ConnectButtondocumentation to include usage ofonClose.NetworkSwitcherButtonto utilize the newonClosecallback.NetworkSwitcherButtonand related components.ChainIconandfetchChainIconfor better icon resolution.