Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move execute out to be api endpoint #5766

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

eabdelmoneim
Copy link
Contributor

@eabdelmoneim eabdelmoneim commented Dec 16, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the documentation for the Context Filtering section in the page.mdx file, including renaming it to Context Filters and adding new details about filtering by wallet addresses.

Detailed summary

  • Renamed section from Context Filtering to Context Filters.
  • Added wallet_addresses to the context filter JSON example.
  • Clarified comments in the JSON example regarding chain IDs and contract addresses.
  • Updated benefits to include targeting specific wallet addresses.
  • Renamed Execute Command section to Execute.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Eiman <[email protected]>
@eabdelmoneim eabdelmoneim requested a review from a team as a code owner December 16, 2024 22:14
@eabdelmoneim eabdelmoneim requested a review from a team December 16, 2024 22:14
@eabdelmoneim eabdelmoneim requested a review from a team as a code owner December 16, 2024 22:14
Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 96213d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:34pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 16, 2024 10:34pm
thirdweb-www ⬜️ Skipped (Inspect) Dec 16, 2024 10:34pm
wallet-ui ⬜️ Skipped (Inspect) Dec 16, 2024 10:34pm

Copy link

graphite-app bot commented Dec 16, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (4fda846) to head (96213d3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5766   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 66ed359
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 2.5 s (-5.42% 🔽) 3.3 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 4.6 s (-12.34% 🔽) 6.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 326 ms (+108.55% 🔺) 437 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 118 ms (+102.16% 🔺) 128 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 450 ms (-35.32% 🔽) 832 ms

Verified

This commit was signed with the committer’s verified signature.
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 16, 2024 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 16, 2024 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 16, 2024 22:25 Inactive
@joaquim-verges joaquim-verges merged commit 8e326cc into main Dec 16, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the eabdelmoneim-nebuladocs-api branch December 16, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants