CVE-2023-3961:s3: smbd: Remove the SMB_ASSERT() that crashes on bad p…

…ipenames. We correctly handle this and just return ENOENT (NT_STATUS_OBJECT_NAME_NOT_FOUND). Remove knowfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15422 Signed-off-by: Jeremy Allison <[email protected]>
thoke · Oct 10, 2023 · 5ed25ef · 5ed25ef
1 parent c39f90a
commit 5ed25ef
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/selftest/knownfail.d/badpipename b/selftest/knownfail.d/badpipename
diff --git a/source3/rpc_client/local_np.c b/source3/rpc_client/local_np.c
@@ -551,11 +551,6 @@ struct tevent_req *local_np_connect_send(
 	{
 		DBG_DEBUG("attempt to connect to invalid pipe pathname %s\n",
 			lower_case_pipename);
-		/*
-		 * For now, panic the server until we have
-		 * the test code in place.
-		 */
-		SMB_ASSERT(false);
 		tevent_req_error(req, ENOENT);
 		return tevent_req_post(req, ev);
 	}