s3: smbd: Now we have shown dst_dirfsp is always NULL, remove the par…

…ameter from rename_internals(). Signed-off-by: Jeremy Allison <[email protected]> Reviewed-by: Ralph Boehme <[email protected]>
thoke · Sep 19, 2023 · e94796e · e94796e
1 parent c38815b
commit e94796e
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 5 deletions.
diff --git a/source3/smbd/proto.h b/source3/smbd/proto.h
@@ -982,7 +982,6 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx,
 			struct smb_request *req,
 			struct files_struct *src_dirfsp,
 			struct smb_filename *smb_fname_src,
-			struct files_struct *dst_dirfsp,
 			struct smb_filename *smb_fname_dst,
 			const char *dst_original_lcomp,
 			uint32_t attrs,

diff --git a/source3/smbd/smb1_nttrans.c b/source3/smbd/smb1_nttrans.c
@@ -1577,7 +1577,6 @@ void reply_ntrename(struct smb_request *req)
 						req,
 						src_dirfsp,
 						smb_fname_old,
-						NULL,
 						smb_fname_new,
 						dst_original_lcomp,
 						attrs,

diff --git a/source3/smbd/smb1_reply.c b/source3/smbd/smb1_reply.c
@@ -6481,7 +6481,6 @@ void reply_mv(struct smb_request *req)
 				req,
 				src_dirfsp, /* src_dirfsp */
 				smb_fname_src,
-				NULL, /* dst_dirfsp */
 				smb_fname_dst,
 				dst_original_lcomp,
 				attrs,

diff --git a/source3/smbd/smb2_reply.c b/source3/smbd/smb2_reply.c
@@ -1847,7 +1847,6 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx,
 			struct smb_request *req,
 			struct files_struct *src_dirfsp,
 			struct smb_filename *smb_fname_src,
-			struct files_struct *dst_dirfsp,
 			struct smb_filename *smb_fname_dst,
 			const char *dst_original_lcomp,
 			uint32_t attrs,

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
@@ -4764,7 +4764,6 @@ static NTSTATUS smb_file_rename_information(connection_struct *conn,
 					req,
 					NULL, /* src_dirfsp */
 					smb_fname_src,
-					NULL,
 					smb_fname_dst,
 					dst_original_lcomp,
 					0,